Tim Vaillancourt
c940a85a28
Merge pull request #835 from ajm188/handle_driver_timeout_error
...
Add a check to rows.Err after processing all rows
2020-08-20 14:10:47 +02:00
Tim Vaillancourt
8b3a8bef0a
Merge branch 'master' into handle_driver_timeout_error
2020-08-19 23:20:10 +02:00
Tim Vaillancourt
ebb1de5cdf
Merge pull request #562 from github/limitation-encrypted-binlogs
...
Documenting limitation: encrypted binlogs
2020-08-19 22:47:21 +02:00
Tim Vaillancourt
81a9538d6f
Merge branch 'master' into limitation-encrypted-binlogs
2020-08-19 22:46:40 +02:00
Tim Vaillancourt
f268259f5e
Merge branch 'master' into handle_driver_timeout_error
2020-08-19 22:04:55 +02:00
Tim Vaillancourt
5e953b7e3e
Merge pull request #878 from github/parse-alter-statement
...
Support a complete ALTER TABLE statement in --alter (merge PR)
2020-08-19 22:04:15 +02:00
Tim Vaillancourt
10724f08c5
Merge branch 'parse-alter-statement' of https://github.com/openark/gh-ost into parse-alter-statement
2020-08-19 21:39:36 +02:00
Tim Vaillancourt
720182f58b
Merge pull request #824 from github/connection-timeout
...
Support --mysql-timeout flag
2020-08-19 21:38:31 +02:00
Tim Vaillancourt
28bbe67c6d
Merge branch 'master' into connection-timeout
2020-08-19 21:08:22 +02:00
Tim Vaillancourt
835e86e682
Merge pull request #823 from github/update-go-sql-driver-2020-02
...
Update go-sql-driver to latest
2020-08-19 21:07:58 +02:00
Tim Vaillancourt
2bb40605d6
Merge branch 'master' into update-go-sql-driver-2020-02
2020-08-19 21:06:50 +02:00
Tim Vaillancourt
06cd4a0a46
Merge pull request #877 from github/workflow-upload-artifact
...
Workflow upload artifact
2020-08-19 21:01:48 +02:00
Tim Vaillancourt
d5eac588ac
Merge branch 'workflow-upload-artifact' of https://github.com/openark/gh-ost into workflow-upload-artifact
2020-08-19 20:59:16 +02:00
Tim Vaillancourt
4bfbe90fca
Merge pull request #876 from github/golang1.14
...
Update to golang:1.14.7, add @timvaillancourt to README.md
2020-08-19 20:54:44 +02:00
Tim Vaillancourt
0ac3a3833d
Merge branch 'master' into golang1.14
2020-08-19 20:27:47 +02:00
Tim Vaillancourt
42bd9187c1
Use 1.14.7
2020-08-19 20:27:11 +02:00
Tim Vaillancourt
25d28855b2
Copy of PR https://github.com/github/gh-ost/pull/861
2020-08-19 20:21:40 +02:00
Tim Vaillancourt
7f0254f30b
Merge branch 'master' into update-go-sql-driver-2020-02
2020-08-19 19:17:50 +02:00
Tim Vaillancourt
f334dbde5e
Merge pull request #810 from yaserazfar/check_unchecked_errors
...
Adds error checking for an err variable that was left unchecked
2020-08-14 17:03:10 +02:00
Tim Vaillancourt
4bbc8deb77
Fix tabs from merge conflict
2020-08-13 15:50:38 +02:00
Tim Vaillancourt
5b6da5b7f3
Merge branch 'master' into handle_driver_timeout_error
2020-08-13 15:49:34 +02:00
Shlomi Noach
ae4dd1867a
extra unit test checks
2020-07-29 15:06:13 +03:00
Shlomi Noach
b54d256725
Merge branch 'master' into workflow-upload-artifact
2020-07-28 11:40:21 +03:00
Shlomi Noach
34d1624dde
Merge pull request #1 from openark/golang1.14
...
Using golang 1.14
2020-07-28 11:39:37 +03:00
Shlomi Noach
b9d400abd8
Merge branch 'master' into workflow-upload-artifact
2020-07-27 10:28:16 +03:00
Shlomi Noach
d1fcef4c3d
Merge branch 'master' into golang1.14
2020-07-27 10:24:09 +03:00
Shlomi Noach
731df3cd15
comments
2020-07-23 14:04:14 +03:00
Shlomi Noach
88c73c0338
Merge branch 'master' into parse-alter-statement
2020-07-23 14:02:38 +03:00
Shlomi Noach
87595b1780
Merge pull request #6 from github/master
...
Updates from upstream
2020-07-23 14:01:49 +03:00
Shlomi Noach
c9249f2b71
Updating and using AlterTableOptions
2020-07-23 11:38:05 +03:00
Shlomi Noach
f482356a94
Merge branch 'master' into parse-alter-statement
2020-07-22 12:36:59 +03:00
Shlomi Noach
6c7b4736e1
Support a complete ALTER TABLE statement in --alter
2020-07-22 12:33:02 +03:00
Justin Fudally
c07d08f8b5
Merge pull request #864 from github/logging-interface-contrib
...
Logging interface contrib
2020-07-21 16:40:50 -05:00
Justin Fudally
b02900ae06
Merge branch 'master' into logging-interface-contrib
2020-07-21 16:01:29 -05:00
Justin Fudally
6b6f9eccf4
Merge pull request #789 from abeyum/master
...
implement a logging interface
2020-07-21 15:57:38 -05:00
Shlomi Noach
8eb300bdc8
expect 1.14 and above in build scripts; update to readme.md
2020-06-29 09:52:47 +03:00
Shlomi Noach
2b71b73285
Actions/workflows: upload binary artifact
2020-06-28 08:57:19 +03:00
Shlomi Noach
fb4aca1567
checksums
2020-06-28 08:49:30 +03:00
Shlomi Noach
1a8c372947
Using golang 1.14
2020-06-28 08:39:16 +03:00
Shuode Li
57955b968b
Merge branch 'master' into master
2020-05-06 00:15:57 -07:00
Andrew Mason
90ad7a061f
Handle the rest of rows.Err cases
2020-04-21 12:50:23 -04:00
Andrew Mason
61de098072
Add a check to rows.Err after processing all rows
...
Closes #822 .
In https://github.com/go-sql-driver/mysql/issues/1075 , @acharis notes
that the way the go-sql driver is written, query timeout errors don't
get set in `rows.Err()` until _after_ a call to `rows.Next()` is made.
Because this kind of error means there will be no rows in the result
set, the `for rows.Next()` will never enter the for loop, so we must
check the value of `rows.Err()` after the loop, and surface the error up
appropriately.
2020-03-31 16:25:16 -04:00
Justin Fudally
4dab06e92b
Merge pull request #833 from github/jfudally-throttle-fix
...
Throttle on HTTP throttle error
2020-03-30 14:38:56 -05:00
Justin Fudally
2178b5947b
remove spammy error
2020-03-30 10:05:23 -05:00
Justin Fudally
5816ede7b3
add error message
2020-03-30 09:55:49 -05:00
Justin Fudally
7893f8e1c3
catch error in collectFunc
2020-03-30 09:53:10 -05:00
Justin Fudally
df60fa4204
add error logging
2020-03-25 16:06:17 -05:00
Justin Fudally
57cf5f3c90
add override to ignore http errors
2020-03-25 15:58:32 -05:00
Justin Fudally
46dabd338b
go fmt
2020-03-25 15:48:19 -05:00
Justin Fudally
d31f3aac0c
Add CLI flag for ignoring http errors
2020-03-25 15:47:56 -05:00
