Paulo Bittencourt
2f80c9d424
Used the source column definition to fetch and convert insert values
...
When processing binlog insert statements, we want to use `sharedColumns`
to decide which values to fetch and convert from the insert DML event.
We only want to `mappedShareColumns` to define the column names in the
`replace into ...` statement.
2016-09-14 11:28:30 -04:00
Paulo Bittencourt
25b5474cfa
Add test case for renaming a column and only applying inserts
...
This catches a bug in `sql.BuildDMLInsertQuery` where we we are fetching
the insert values using the renamed column's name, and end up fetching
the value of the wrong column.
The test in `localtests/rename` did not catch this because binlog
update events were "correcting" the error, as they follow a different
code path that does not contain the bug.
2016-09-14 11:28:30 -04:00
Paulo Bittencourt
671fc71067
Add test case for altering a column's charset
...
This catches a bug in `sql.BuildDMLInsertQuery` where we are using the target
column's Charset to drive the value conversion. In the case where we are
altering the charset, the Charset used for conversion will be different than
the original column's charset, resulting in an erroneous conversion.
2016-09-14 11:26:43 -04:00
Shlomi Noach
eac6a726de
Merge pull request #231 from github/named-cut-over
...
Named cut over
2016-09-13 08:23:00 -07:00
Shlomi Noach
7517d48776
updated version
2016-09-13 05:35:43 -07:00
Shlomi Noach
a7627091a7
Merge branch 'master' into named-cut-over
2016-09-13 05:25:16 -07:00
Shlomi Noach
5215dd5999
Merge pull request #234 from github/vendor-charmap
...
added charset dependencies
2016-09-13 05:24:19 -07:00
Shlomi Noach
daed73fa4e
Merge pull request #232 from github/end-rowcopy-progress
...
rowcount progress at 100% when row-copy completes
2016-09-12 17:22:56 -07:00
Shlomi Noach
f81b51e9d6
added charset dependencies
2016-09-12 13:32:24 -07:00
Shlomi Noach
e5e0444cc6
supporting --force-named-cut-over
...
- when given, user _must_ specify table name
and of course table name must match migrated table
2016-09-12 19:17:36 +02:00
Shlomi Noach
0a8be1dd22
excplicitly breaking on NoPrintStatusRule
2016-09-12 17:39:56 +02:00
Shlomi Noach
1c6f828091
refactored server command into server.go
...
- added support for cut-over=<tablename>
- refactored more code into context
2016-09-12 12:38:14 +02:00
Shlomi Noach
16fc19b157
rowcount progress at 100% when row-copy completes
2016-09-12 10:25:55 +02:00
Shlomi Noach
c3e65d45e2
Merge pull request #227 from github/testing-chartset
...
added charset support & tests
2016-09-09 14:59:01 +02:00
Shlomi Noach
f4693274fb
Extracted and generalized encoding logic to encoding.go
2016-09-08 09:37:22 +02:00
Shlomi Noach
dc3a03ad6f
added mixed-charset tests
2016-09-08 09:27:18 +02:00
Shlomi Noach
791d963ea0
Character set recognition and manipulation
...
- Identifying textual characters sets; converting into specific type when applying dml events
- Refactored `ColumnsList`: introducing `Column` type
- Refactored `unsigned` handling, as part of `Column`
- `Column` type supports `convertArg()`: converting value of argument according to column data type
- DB URI attempts `utf8mb4,utf8,latin1` charsets in that order (first one to be recognized wins)
- Local tests filter by pattern
- Local tests append table schema on failure
- Local tests do not have postpone flag file
- Added character set local tests: `utf8`, `utf8mb4`, `latin1`
2016-09-07 14:24:11 +02:00
Shlomi Noach
f646021527
added utf8mb4 test
2016-09-06 12:15:53 +02:00
Shlomi Noach
095c607f45
clarified test argument
2016-09-06 09:46:11 +02:00
Shlomi Noach
31a3add1b0
text tests
2016-09-06 09:38:41 +02:00
Shlomi Noach
0adf258b13
added charset tests
2016-09-06 09:36:29 +02:00
Shlomi Noach
7a4ae014d5
Merge pull request #223 from github/assume-master-host
...
support for --assume-master-host, master-master/tungsten
2016-09-05 09:58:35 +02:00
Shlomi Noach
88f2af8111
support for --assume-master-host, master-master/tungsten
2016-09-02 13:09:18 +02:00
Shlomi Noach
96f108d3b4
Merge pull request #221 from twotwotwo/override-applier-host
...
Add -override-applier-host for use with -allow-master-master
2016-09-02 11:32:04 +02:00
Shlomi Noach
0f2a43dc54
Merge pull request #222 from github/hooks-more-info
...
Hooks: more environment variables
2016-09-02 10:55:04 +02:00
Shlomi Noach
4331593741
elaborate hooks doc
2016-09-02 10:51:22 +02:00
Shlomi Noach
a58e80387e
More environment variables in hooks
2016-09-02 10:48:29 +02:00
Shlomi Noach
75d225353f
Merge pull request #220 from Wattpad/exit-on-hook-replication-stop-failure
...
Fail operation if onStopReplication hook fails
2016-09-02 09:39:43 +02:00
Shlomi Noach
fd42ccfb49
Merge pull request #219 from github/doc-updates
...
Doc updates: subsecond throttling and more
2016-09-02 08:54:37 +02:00
Shlomi Noach
736c8a042b
typos
2016-09-02 08:54:21 +02:00
Shlomi Noach
3ee006968a
Merge pull request #218 from github/eta-status
...
Eta status
2016-09-02 08:52:56 +02:00
randall
82110fcfcf
Add -override-applier-host for use with -allow-master-master
...
for configurations where writes are meant to go to one master, but gh-ost can't automatically determine which
2016-09-01 20:29:26 -07:00
Paulo Bittencourt
e3662f2398
Fail operation if onStopReplication hook fails
2016-09-01 15:58:20 -04:00
Shlomi Noach
ad3d1b2384
beautify
2016-09-01 13:45:37 +02:00
Shlomi Noach
34a7306f4b
elaborate sub-second lag throttling
2016-09-01 13:44:30 +02:00
Shlomi Noach
25400cdf96
clarified throttling logic; indicating sub-second lag
2016-09-01 13:20:39 +02:00
Shlomi Noach
9c92779939
begin documentation on sub-second replication lag throttling
2016-09-01 13:13:04 +02:00
Shlomi Noach
5773fd22ae
more comments on cut-over
2016-09-01 13:12:24 +02:00
Shlomi Noach
d5161c6a89
updating documentation following recent developments
...
describing `--concurrent-rowcount`
2016-09-01 12:46:54 +02:00
Shlomi Noach
43a3ce8a58
updated version
2016-09-01 10:51:56 +02:00
Shlomi Noach
c562df42cd
status: State and ETA decoupling
2016-09-01 10:51:40 +02:00
Shlomi Noach
dfde634cf6
Merge pull request #217 from github/clarify-critical-load
...
Modified definition of `critical-load`
2016-09-01 09:21:26 +02:00
Gillian Gunson
ab70e011ad
Added info to critical-load. Format changes
2016-08-31 18:10:02 -07:00
Shlomi Noach
904215e286
Merge pull request #204 from github/reduce-minimum-max-lag
...
Reduce minimum maxLagMillisecondsThrottleThreshold to 100ms
2016-08-31 09:29:16 +02:00
Shlomi Noach
f94651f4fb
Merge pull request #213 from github/rowcopy-complete-100
...
indicating 100% when rowcopy is complete
2016-08-31 09:27:33 +02:00
Shlomi Noach
aef56c55f7
indicating 100% when rowcopy is complete
2016-08-30 17:02:29 +02:00
Shlomi Noach
b2c71931c6
refactored all throttling code into throttler.so
2016-08-30 12:25:45 +02:00
Shlomi Noach
23357d0643
WIP: decoupling general throttling from throttle logic
2016-08-30 11:32:17 +02:00
Shlomi Noach
75b2542f26
Merge branch 'master' into reduce-minimum-max-lag
2016-08-30 09:47:33 +02:00
Shlomi Noach
6b65ab44de
Merge pull request #211 from github/fix-path
...
fixed import path
2016-08-30 09:46:04 +02:00