gh-ost/go
Andrew Mason 6e1daf90ee
Check RowsAffected when applying DML events to get more accurate statistics (#844)
* Check RowsAffected when applying DML events to get more accurate statistics

Addresses #600.

When applying a DML event, check the RowsAffected on the `Result`
struct. Since all DML event queries are point queries, this will only
ever be 0 or 1. The applier then takes this value and multiplies by
the `rowsDelta` of the event, resulting in a properly-signed, accurate
row delta to use in the statistics.

If an error occurs here, log it, but do not surface this as an
actual error .. simply assume the DML affected a row and move on. It
will be inaccurate, but this is already the case.

* Fix import

* update wording to warning log message

Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>

Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>
2021-07-14 16:48:03 +02:00
..
base Add go mod (#935) 2021-06-24 20:19:37 +02:00
binlog add migrationcontext to gomysql_reader 2019-10-08 13:49:15 -04:00
cmd/gh-ost Add go mod (#935) 2021-06-24 20:19:37 +02:00
logic Check RowsAffected when applying DML events to get more accurate statistics (#844) 2021-07-14 16:48:03 +02:00
mysql Add go mod (#935) 2021-06-24 20:19:37 +02:00
os Add go mod (#935) 2021-06-24 20:19:37 +02:00
sql Add go mod (#935) 2021-06-24 20:19:37 +02:00