From 16c7484c171f24e7c10cddff05eca54455b9febb Mon Sep 17 00:00:00 2001 From: William Melody Date: Sun, 12 Apr 2020 16:09:12 -0700 Subject: [PATCH] Improve test failure messages. --- test/backups.bats | 4 ++++ test/test_helper.bash | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/test/backups.bats b/test/backups.bats index 740de2b..1861497 100755 --- a/test/backups.bats +++ b/test/backups.bats @@ -26,6 +26,8 @@ load test_helper run "${_HOSTS}" backups printf "\${status}: %s\\n" "${status}" printf "\${output}: '%s'\\n" "${output}" + printf "\${_HOSTS_TEMP_PATH}: '%s'\\n" "${_HOSTS_TEMP_PATH}" + printf "\${HOSTS_PATH}: '%s'\\n" "${HOSTS_PATH}" _expected="\ No backups found. Create a new backup: hosts backups create" @@ -42,6 +44,8 @@ No backups found. Create a new backup: run "${_HOSTS}" backups printf "\${status}: %s\\n" "${status}" printf "\${output}: '%s'\\n" "${output}" + printf "\${_HOSTS_TEMP_PATH}: '%s'\\n" "${_HOSTS_TEMP_PATH}" + printf "\${HOSTS_PATH}: '%s'\\n" "${HOSTS_PATH}" [[ "${lines[0]}" =~ hosts_test ]] [[ "${lines[0]}" =~ '--backup-' ]] [[ "${lines[1]}" =~ hosts_test ]] diff --git a/test/test_helper.bash b/test/test_helper.bash index ccad9c0..04cd716 100644 --- a/test/test_helper.bash +++ b/test/test_helper.bash @@ -14,7 +14,7 @@ setup() { export _HOSTS_TEMP_DIR="/tmp" export _HOSTS_TEMP_PATH - _HOSTS_TEMP_PATH="$(mktemp ${_HOSTS_TEMP_DIR}/hosts_test.XXXXXX)" || exit 1 + _HOSTS_TEMP_PATH="$(mktemp "${_HOSTS_TEMP_DIR}/hosts_test.XXXXXX")" || exit 1 cat "${BATS_TEST_DIRNAME}/fixtures/hosts" > "${_HOSTS_TEMP_PATH}" export HOSTS_PATH="${_HOSTS_TEMP_PATH}"