octoleo
/
lsyncd
mirror of https://github.com/octoleo/lsyncd.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add sanity checking in filenames and paths. 

Check files exist, and check paths are specified absolute.
I am relying on paths starting from '/' when they are absolute.

daemon() will chdir to /, and that means giving relative paths to this
program will give unexpected (to the user) results.
This commit is contained in:
Junichi Uekawa 2008-10-08 04:08:56 +00:00
parent f62c1f3cc2
commit 03a32b6e1e
1 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
lsyncd.c
View File

@ -800,6 +800,35 @@ bool scan_homes()
return true;
}
/**
* Utility function to check file exists. Print out error message and die.
*
* @param filename filename to check
*/
void check_file_exists(const char* filename)
{
struct stat st;
if (-1==stat(filename, &st)) {
printlogf(LOG_ERROR, "File [%s] does not exist\n", filename);
exit (-1);
}
}
/**
* Utility function to check given path is absolute path.
*
* @param filename filename to check
*/
void check_absolute_path(const char* filename)
{
if (filename[0] != '/') {
printlogf(LOG_ERROR, "Filename [%s] is not an absolute path\n", filename);
exit (-1);
}
}
/**
* Prints the help text and exits 0.
*
@ -907,6 +936,7 @@ bool parse_options(int argc, char **argv)
}
}
if (optind + 2 != argc) {
printf("Error: please specify SOURCE and TARGET (see --help)\n");
exit(-1);
@ -922,6 +952,15 @@ bool parse_options(int argc, char **argv)
}
printlogf(LOG_NORMAL, "syncing %s -> %s\n", option_source, option_target);
/* sanity checking here */
if (exclude_file) {
check_absolute_path(exclude_file);
check_file_exists(exclude_file);
}
if (pidfile) {
check_absolute_path(pidfile);
}
return true;
}