From 05e2439c56084322519822a7fcb672340568ac8e Mon Sep 17 00:00:00 2001 From: Ronan Jouchet Date: Mon, 4 Oct 2021 09:32:52 -0400 Subject: [PATCH] HACKING.md: Document one more place to look when major-upgrading Electron --- HACKING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/HACKING.md b/HACKING.md index 90593e8..3dc5ce9 100644 --- a/HACKING.md +++ b/HACKING.md @@ -117,12 +117,13 @@ but is painful to do manually. Do yourself a favor and install a ## Maintainers corner -### Deps: major-updating Electron +### Deps: major-upgrading Electron When a new major [Electron release](https://github.com/electron/electron/releases) occurs, 1. Wait a few weeks to let it stabilize. Never upgrade Nativefier to a `.0.0`. -2. Thoroughly digest the new version's [breaking changes](https://www.electronjs.org/docs/breaking-changes), +2. Thoroughly digest the new version's [breaking changes](https://www.electronjs.org/docs/breaking-changes) + (also via the [Releases page](https://github.com/electron/electron/releases), the content is different), grepping our codebase for every changed API. - If called for by the breaking changes, perform the necessary API changes 3. Bump `src/constants.ts` / `DEFAULT_ELECTRON_VERSION` & `DEFAULT_CHROME_VERSION`