From 46424f9795903427263b72e9abad4da1ae66e567 Mon Sep 17 00:00:00 2001 From: Adam Weeden Date: Tue, 21 Sep 2021 17:32:55 -0400 Subject: [PATCH] Make macOS "bundle identifier" mention Nativefier (fix #866) (#1259) * Make macos bundle identifier mention nativefier * Fix @types/debug here too Co-authored-by: Ronan Jouchet --- src/build/prepareElectronApp.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/build/prepareElectronApp.ts b/src/build/prepareElectronApp.ts index 187a3fa..fb7f07d 100644 --- a/src/build/prepareElectronApp.ts +++ b/src/build/prepareElectronApp.ts @@ -158,7 +158,7 @@ function changeAppPackageJsonName( appPath: string, name: string, url: string, -): void { +): string { const packageJsonPath = path.join(appPath, '/package.json'); const packageJson = parseJson( fs.readFileSync(packageJsonPath).toString(), @@ -171,6 +171,8 @@ function changeAppPackageJsonName( log.debug(`Updating ${packageJsonPath} 'name' field to ${normalizedAppName}`); fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2)); + + return normalizedAppName; } /** @@ -212,9 +214,10 @@ export async function prepareElectronApp( } catch (err: unknown) { log.error('Error copying injection files.', err); } - changeAppPackageJsonName( + const normalizedAppName = changeAppPackageJsonName( dest, options.packager.name as string, options.packager.targetUrl, ); + options.packager.appBundleId = `com.electron.nativefier.${normalizedAppName}`; }