From 6f4ae587c437944f7f44ca2aad2fe21b99817586 Mon Sep 17 00:00:00 2001 From: Ronan Jouchet Date: Sat, 25 Dec 2021 16:53:06 -0500 Subject: [PATCH] build/ci workflow: pass the node version number with the format expected by GHA/setup-node and avoid warning "Not found in manifest. Falling back to download directly from Node" --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b1c215c..e8ec208 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,7 +14,7 @@ jobs: matrix: node-version: # Align the top Node version here with: 1. linter conditions later below, 2. publish.yml. - - 17.x + - '17' # Bumping the minimum required Node version? You must bump: # 1. package.json -> engines.node # 2. package.json -> devDependencies.@types/node @@ -23,7 +23,7 @@ jobs: # # Here in ci.yml, we want to always run the oldest version we require in # package.json -> engines.node, to be sure Nativefier runs on this minimum - - 12.x + - '12' platform: [ubuntu-latest, macos-latest, windows-latest] runs-on: ${{ matrix.platform }} steps: