From 7c5b2bb68f66a4a6adc7d8d6dd5ba121309573b8 Mon Sep 17 00:00:00 2001 From: Ronan Jouchet Date: Sun, 6 Dec 2020 13:57:27 -0500 Subject: [PATCH] Bump default Electron to 11.0.3, bump dep eslint-config-prettier to 7.x, bump version to something far away from current Electron version Rationale for nonsensical major version bump: around Nativefier 8.x, versions of Nativefier and Electron aligned, by release schedule coincidence. Since Nativefier has little breaking changes, it was great: as Electron releases are breaking, Nativefier had no breaking changes, I bumped our major version on new major Electron, and everything was good. Except *now*, as I have a breaking change, that would bump Nativefier to 12.x, which would be confusing since we'd still default to Electron 11 :-/ . -> To keep respecting semver and reduce confusion, bumping Nativefier version to something far ahead. No it doesn't matter, version number are meaningless anyway (well, outside of semver, whose respect is precisely the point here). --- package.json | 8 ++++---- src/constants.ts | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index eeed32a..ebb9cd3 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "nativefier", - "version": "11.0.2", + "version": "42.0.0", "description": "Wrap web apps natively", "license": "MIT", "author": "Goh Jia Hao", @@ -76,10 +76,10 @@ }, "devDependencies": { "@types/jest": "26.x", - "@typescript-eslint/eslint-plugin": "^4.6.1", - "@typescript-eslint/parser": "^4.6.1", + "@typescript-eslint/eslint-plugin": "4.x", + "@typescript-eslint/parser": "4.x", "eslint": "7.x", - "eslint-config-prettier": "6.x", + "eslint-config-prettier": "7.x", "eslint-plugin-prettier": "3.x", "jest": "26.x", "prettier": "2.x", diff --git a/src/constants.ts b/src/constants.ts index 3a9ce98..55ee779 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -3,7 +3,7 @@ import * as path from 'path'; export const DEFAULT_APP_NAME = 'APP'; // Update both together -export const DEFAULT_ELECTRON_VERSION = '11.0.2'; +export const DEFAULT_ELECTRON_VERSION = '11.0.3'; export const DEFAULT_CHROME_VERSION = '87.0.4280.67'; export const ELECTRON_MAJOR_VERSION = parseInt(