From b7aada7967f0f64e2346a02f02419d89e5f22e3f Mon Sep 17 00:00:00 2001 From: Jia Hao Date: Thu, 10 Mar 2016 12:46:09 +0800 Subject: [PATCH] Fix bug in setting icon on windows for windows --- src/build/iconBuild.js | 3 +-- src/helpers/helpers.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/build/iconBuild.js b/src/build/iconBuild.js index d84e7e0..07e700d 100644 --- a/src/build/iconBuild.js +++ b/src/build/iconBuild.js @@ -30,7 +30,6 @@ function iconBuild(options, callback) { if (options.platform === 'win32') { if (!iconIsIco(options.icon)) { - console.warn('Icon should be an .ico to package for Windows'); returnCallback(); return; } @@ -41,7 +40,7 @@ function iconBuild(options, callback) { returnCallback(); }) .catch(error => { - console.warn('Skipping icon conversion from `.png` to `.icns`: ', error); + console.warn('Skipping process to make .ico icon contain only a single image: ', error); returnCallback(); }); return; diff --git a/src/helpers/helpers.js b/src/helpers/helpers.js index d4dba7d..abe502b 100644 --- a/src/helpers/helpers.js +++ b/src/helpers/helpers.js @@ -5,7 +5,7 @@ function isOSX() { } function isWindows() { - return os.platform() === 'windows'; + return os.platform() === 'win32'; } export default {