octoleo/nativefier
2
2
Fork 0
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-09-27 03:59:01 +00:00
Code Issues Releases Activity

Fix bug in setting icon on windows for windows

Browse Source
This commit is contained in:
Jia Hao 2016-03-10 12:46:09 +08:00
parent c3374618d9
commit b7aada7967
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/build/iconBuild.js
View File

@ -30,7 +30,6 @@ function iconBuild(options, callback) {
if (options.platform === 'win32') { if (options.platform === 'win32') {
if (!iconIsIco(options.icon)) { if (!iconIsIco(options.icon)) {
console.warn('Icon should be an .ico to package for Windows');
returnCallback(); returnCallback();
return; return;
} }
@ -41,7 +40,7 @@ function iconBuild(options, callback) {
returnCallback(); returnCallback();
}) })
.catch(error => { .catch(error => {
console.warn('Skipping icon conversion from `.png` to `.icns`: ', error); console.warn('Skipping process to make .ico icon contain only a single image: ', error);
returnCallback(); returnCallback();
}); });
return; return;

2
src/helpers/helpers.js
View File

@ -5,7 +5,7 @@ function isOSX() {
} }
function isWindows() { function isWindows() {
return os.platform() === 'windows'; return os.platform() === 'win32';
} }
export default { export default {