From d2c7de37a2ef611b77003c5d5f5e3e538f9b2864 Mon Sep 17 00:00:00 2001 From: Adam Weeden Date: Thu, 29 Apr 2021 13:24:15 -0400 Subject: [PATCH] Add newly discovered Google internal login page (#1167) --- app/src/helpers/helpers.test.ts | 3 +++ app/src/helpers/helpers.ts | 1 + 2 files changed, 4 insertions(+) diff --git a/app/src/helpers/helpers.test.ts b/app/src/helpers/helpers.test.ts index f4c1404..10db20d 100644 --- a/app/src/helpers/helpers.test.ts +++ b/app/src/helpers/helpers.test.ts @@ -69,6 +69,8 @@ const testLoginPages = [ 'https://github.com/sessions/two-factor/webauth', 'https://accounts.google.co.uk', 'https://accounts.google.com', + 'https://mail.google.com/accounts/SetOSID', + 'https://mail.google.co.uk/accounts/SetOSID', 'https://accounts.google.de', 'https://linkedin.co.uk/uas/login', 'https://linkedin.com/uas/login', @@ -100,6 +102,7 @@ const testNonLoginPages = [ 'https://github.com/org/nativefier', 'https://twitter.com/marcoroth_/status/1325938620906287104', 'https://appleid.apple.com/account', + 'https://mail.google.com/', ]; test.each(testNonLoginPages)( diff --git a/app/src/helpers/helpers.ts b/app/src/helpers/helpers.ts index 962631a..60952ae 100644 --- a/app/src/helpers/helpers.ts +++ b/app/src/helpers/helpers.ts @@ -25,6 +25,7 @@ function isInternalLoginPage(url: string): boolean { `facebook\\.[a-zA-Z\\.]*\\/login`, // Facebook 'github\\.[a-zA-Z\\.]*\\/(?:login|session)', // GitHub 'accounts\\.google\\.[a-zA-Z\\.]*', // Google + 'mail\\.google\\.[a-zA-Z\\.]*\\/accounts/SetOSID', // Google 'linkedin\\.[a-zA-Z\\.]*/uas/login', // LinkedIn 'login\\.live\\.[a-zA-Z\\.]*', // Microsoft 'okta\\.[a-zA-Z\\.]*', // Okta