2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-09-27 20:09:03 +00:00
Commit Graph

23 Commits

Author SHA1 Message Date
Kenneth G. Franqueiro
a157f716a5 Implement multi-target options and refactor code
This adds support for --all, --platform=all, and --arch=all.

In order to accommodate outputting multiple directories for multiple
platforms and architectures, this also implements a new directory
structure under the output folder (distinguished by both platform and
arch).  This structure is applied even to OS X distributions, which
formerly were output directly to an .app folder.  This could be considered
a backwards-incompatible change.

One other backwards-incompatible change is the value that the packager
function passes to the callback, which is now always an array of paths,
rather than just a single path.

The behavior of the icon option has also been modified to use its
basename and apply .ico or .icns depending on platform, to make it
usable with --all and --platform=all.  This attempts to maximize
backwards compatibility, by allowing a full filename to be specified,
but replacing the filename's extension with what is appropriate for
each target platform.  Alternatively, the extension can now be omitted.

In the process of implementing this, it became evident that some things
were being done in 3 different places, and weren't always being done
consistently, so I've deduplicated everything I could.

This also includes a few other changes to improve stability for
multi-target runs, and other fixes:

* Avoid targeting darwin if the environment doesn't support symlinks,
  to avoid the process bailing out on Windows
* Implement --overwrite centrally in index.js such that it explicitly
  skips if an output directory already exists, for consistency with
  all target platforms and to avoid any possible errors that would halt
  operation during one target of a multi-target run
* Use ncp instead of mv to move to finalPath, which avoids flakiness
  I noticed when testing on Windows 8 especially with multi-target runs
* Simplify temp directory logic by using a nested structure, so there
  is only one top-level directory to clean up
* Reinstate fix from #55 which seems to have been clobbered by a later
  merge
* linux.createApp now resolves to the final output directory;
  it was formerly resolving to the executable path
* mac.createApp now replaces space with underscore in bundle IDs
* Only the platform modules that are needed are loaded
* The win32 module only loads rcedit if needed

This also fixes a couple of missing updates to docs (readme/usage).

This commit addresses the following issues:

* Resolves #40
* Resolves #38
* Resolves #70
* Works around #71
* Resolves #84 by reinstating #55
2015-06-28 16:57:56 -04:00
Mark Lee
9bcb1a81d9 Rename variable which mirrors the function name 2015-06-09 20:38:09 -07:00
Martin Zagora
5c82a97f05 fix defaultIgnores to be proper reg-exps 2015-05-22 10:28:04 +10:00
Max Ogden
a2f3c1c707 style 2015-05-18 14:10:10 -07:00
Jens Lind
892b15fc30 Ignore this and related modules 2015-05-18 19:51:33 +02:00
Max Ogden
923996f6ca return when erroring early 2015-05-11 12:10:26 -07:00
Ivo Georgiev
ca6af870d3 Validate the --arch argument 2015-05-11 18:22:10 +03:00
Max Ogden
260a16509b breaking change. allow building apps for other platforms 2015-05-10 13:57:42 -07:00
jden
b126237994 add windows support #3 2015-05-06 12:11:03 -07:00
Mark Lee
6634913bb2 Add basic Linux support
Copies both the electron-prebuilt distribution into the app's toplevel
dist directory (by default) and the user's app into the correct subdirectory.
2015-05-05 07:43:09 -07:00
Mark Lee
17803f01d1 Put Mac-specific code in its own file, raise error if platform unsupported 2015-05-05 07:43:09 -07:00
Max Ogden
2f2618f7a0 merge 2015-04-27 12:13:21 -07:00
Max Ogden
290e5c1e35 merge 2015-04-27 12:12:17 -07:00
Max Ogden
198f379d41 rename to electron-packager 2015-04-27 12:09:24 -07:00
Stefan Buck
40f881a718 Add set version support 2015-04-24 15:48:09 +02:00
Stefan Buck
be1c139b5a add --icon support 2015-04-24 14:17:30 +02:00
Mathias Buus
ff12e9ada1 support globally installed atom-shell 2015-04-05 09:04:24 -07:00
Mathias Buus
18871061d5 add custom protocol handler support 2015-04-04 21:26:03 -07:00
Max Ogden
330e376372 dont download atom-shell -- use local version instead 2015-04-04 09:47:01 -07:00
Max Ogden
cbc585393b hoist + reorganize code from #7, and use fs.rename instead of spawn mv 2015-03-23 16:59:46 -07:00
Zach Bruggeman
90b7cbb334 Add prune option
Fixes GH-4
2015-03-23 14:58:28 -07:00
Max Ogden
b1e2e80dbb add --ignore support 2015-03-22 20:14:42 -07:00
Max Ogden
cf7fe77eb6 first working version 2015-03-22 19:51:19 -07:00