octoleo/php-ml
1
0
Fork 0
mirror of https://github.com/Llewellynvdm/php-ml.git synced 2024-11-24 13:57:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix division by zero in ANOVA for small size dataset (#391)

Browse Source
This commit is contained in:
Arkadiusz Kondas 2019-06-22 22:54:47 +02:00 committed by GitHub
parent 4590d5cc32
commit 1a856c9099
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Math/Statistic/ANOVA.php
View File

@ -45,6 +45,10 @@ final class ANOVA
return $s / $dfbn;
}, $ssbn);
$msw = array_map(function ($s) use ($dfwn) {
if ($dfwn === 0) {
return 1;
}
return $s / $dfwn;
}, $sswn);

42
tests/FeatureSelection/SelectKBestTest.php
View File

@ -61,6 +61,48 @@ final class SelectKBestTest extends TestCase
);
}
public function testSelectKBestIssue386(): void
{
$samples = [
[
0.0006729998475705993,
0.0,
0.999999773507577,
0.0,
0.0,
6.66666515671718E-7,
3.33333257835859E-6,
6.66666515671718E-6,
],
[
0.0006729998475849566,
0.0,
0.9999997735289103,
0.0,
0.0,
6.666665156859402E-7,
3.3333325784297012E-6,
1.3333330313718804E-6,
],
];
$targets = [15.5844, 4.45284];
$selector = new SelectKBest(2);
$selector->fit($samples, $targets);
self::assertEquals([
-2.117582368135751E-22,
0.0,
0.0,
0.0,
0.0,
1.0097419586828951E-28,
0.0,
1.4222215779620095E-11,
], $selector->scores());
}
public function testThrowExceptionOnEmptyTargets(): void
{
$this->expectException(InvalidArgumentException::class);