From 89268ecb1afd171943932254c8e4f92077fadac0 Mon Sep 17 00:00:00 2001
From: Jeroen van den Enden <info@endroid.nl>
Date: Thu, 25 Jan 2018 16:12:13 +0100
Subject: [PATCH] Throw exception when libsvm command fails to run (#200)

* Throw exception when libsvm command fails to run

* Update CS
---
 src/Phpml/Exception/LibsvmCommandException.php    | 15 +++++++++++++++
 .../SupportVectorMachine/SupportVectorMachine.php | 15 +++++++++++++--
 2 files changed, 28 insertions(+), 2 deletions(-)
 create mode 100644 src/Phpml/Exception/LibsvmCommandException.php

diff --git a/src/Phpml/Exception/LibsvmCommandException.php b/src/Phpml/Exception/LibsvmCommandException.php
new file mode 100644
index 0000000..01d8079
--- /dev/null
+++ b/src/Phpml/Exception/LibsvmCommandException.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Phpml\Exception;
+
+use Exception;
+
+class LibsvmCommandException extends Exception
+{
+    public static function failedToRun(string $command): self
+    {
+        return new self(sprintf('Failed running libsvm command: "%s"', $command));
+    }
+}
diff --git a/src/Phpml/SupportVectorMachine/SupportVectorMachine.php b/src/Phpml/SupportVectorMachine/SupportVectorMachine.php
index 4565332..f66d5d7 100644
--- a/src/Phpml/SupportVectorMachine/SupportVectorMachine.php
+++ b/src/Phpml/SupportVectorMachine/SupportVectorMachine.php
@@ -5,6 +5,7 @@ declare(strict_types=1);
 namespace Phpml\SupportVectorMachine;
 
 use Phpml\Exception\InvalidArgumentException;
+use Phpml\Exception\LibsvmCommandException;
 use Phpml\Helper\Trainable;
 
 class SupportVectorMachine
@@ -153,7 +154,11 @@ class SupportVectorMachine
 
         $command = $this->buildTrainCommand($trainingSetFileName, $modelFileName);
         $output = '';
-        exec(escapeshellcmd($command), $output);
+        exec(escapeshellcmd($command), $output, $return);
+
+        if ($return !== 0) {
+            throw LibsvmCommandException::failedToRun($command);
+        }
 
         $this->model = file_get_contents($modelFileName);
 
@@ -168,6 +173,8 @@ class SupportVectorMachine
 
     /**
      * @return array|string
+     *
+     * @throws LibsvmCommandException
      */
     public function predict(array $samples)
     {
@@ -178,7 +185,11 @@ class SupportVectorMachine
 
         $command = sprintf('%ssvm-predict%s %s %s %s', $this->binPath, $this->getOSExtension(), $testSetFileName, $modelFileName, $outputFileName);
         $output = '';
-        exec(escapeshellcmd($command), $output);
+        exec(escapeshellcmd($command), $output, $return);
+
+        if ($return !== 0) {
+            throw LibsvmCommandException::failedToRun($command);
+        }
 
         $predictions = file_get_contents($outputFileName);