octoleo/phpseclib
1
0
Fork 0
mirror of https://github.com/phpseclib/phpseclib.git synced 2025-02-02 20:08:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

SSH2: use weakreference when available to stop memory leak

Browse Source
This commit is contained in:
terrafrost 2021-06-19 10:14:45 -05:00
parent f1c4164687
commit 418035c404
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
phpseclib/Net/SSH2.php
View File

@ -1123,7 +1123,7 @@ class SSH2
31 => 'NET_SSH2_MSG_KEX_ECDH_REPLY'] 31 => 'NET_SSH2_MSG_KEX_ECDH_REPLY']
); );
self::$connections[$this->getResourceId()] = $this; self::$connections[$this->getResourceId()] = class_exists('WeakReference') ? \WeakReference::create($this) : $this;
if (is_resource($host)) { if (is_resource($host)) {
$this->fsock = $host; $this->fsock = $host;
@ -4896,7 +4896,10 @@ class SSH2
*/ */
public static function getConnectionByResourceId($id) public static function getConnectionByResourceId($id)
{ {
return isset(self::$connections[$id]) ? self::$connections[$id] : false; if (isset(self::$connections[$id])) {
return self::$connections[$id] instanceof \WeakReference ? self::$connections[$id]->get() : self::$connections[$id];
}
return false;
} }
/** /**
@ -4906,8 +4909,15 @@ class SSH2
*/ */
public static function getConnections() public static function getConnections()
{ {
if (!class_exists('WeakReference')) {
return self::$connections; return self::$connections;
} }
$temp = [];
foreach (self::$connections as $key=>$ref) {
$temp[$key] = $ref->get();
}
return $temp;
}
/* /*
* Update packet types in log history * Update packet types in log history