octoleo/phpseclib
1
0
Fork 0
mirror of https://github.com/phpseclib/phpseclib.git synced 2024-11-17 18:55:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix logic error reading random bytes from /dev/urandom

Browse Source 
Fixes a bug introduced in c2be7e648

Previously, this would return those bytes if the number of bytes read
was **less than** the number of bytes this was trying to read.

In practice, I believe this would mean bytes from /dev/urandom would never
get used.  (Noticed when upgrading phpseclib)
This commit is contained in:
Tyson Andre 2020-04-02 14:32:12 -04:00 committed by terrafrost
parent 5e2951f83a
commit 41eb0d8012
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
phpseclib/Crypt/Random.php
View File

@ -106,7 +106,7 @@ if (!function_exists('crypt_random_string')) {
} }
if ($fp !== true && $fp !== false) { // surprisingly faster than !is_bool() or is_resource() if ($fp !== true && $fp !== false) { // surprisingly faster than !is_bool() or is_resource()
$temp = fread($fp, $length); $temp = fread($fp, $length);
if (strlen($temp) != $length) { if (strlen($temp) == $length) {
return $temp; return $temp;
} }
} }