octoleo/phpseclib
1
0
Fork 0
mirror of https://github.com/phpseclib/phpseclib.git synced 2025-01-27 17:18:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch '2.0'

Browse Source
This commit is contained in:
terrafrost 2019-09-15 17:31:53 -05:00
commit 677a15c122
3 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
phpseclib/Math/BigInteger/Engines/GMP.php
View File

@ -517,7 +517,14 @@ class GMP extends Engine
$result->bitmask = $this->bitmask; $result->bitmask = $this->bitmask;
if ($result->bitmask !== false) { if ($result->bitmask !== false) {
$flip = $result->value < 0;
if ($flip) {
$result->value = -$result->value;
}
$result->value = $result->value & $result->bitmask->value; $result->value = $result->value & $result->bitmask->value;
if ($flip) {
$result->value = -$result->value;
}
} }
return $result; return $result;

1
phpseclib/Math/BigInteger/Engines/PHP.php
View File

@ -157,6 +157,7 @@ abstract class PHP extends Engine
} }
$temp = clone $this; $temp = clone $this;
$temp->bitmask = false;
$temp->is_negative = false; $temp->is_negative = false;
$divisor = new static(); $divisor = new static();

17
tests/Unit/Math/BigInteger/TestCase.php
View File

@ -485,4 +485,21 @@ abstract class Unit_Math_BigInteger_TestCase extends PhpseclibTestCase
$temp = $this->getInstance('-0'); $temp = $this->getInstance('-0');
$this->assertSame($temp->toString(), '0'); $this->assertSame($temp->toString(), '0');
} }
public function testNegativePrecision()
{
$vals = [
'-9223372036854775808', // eg. 8000 0000 0000 0000
'-1'
];
foreach ($vals as $val) {
$x = $this->getInstance($val);
$x->setPrecision(64); // ie. 8 bytes
$this->assertSame($val, "$x");
$r = $x->toBytes(true);
$this->assertSame(8, strlen($r));
$x2 = $this->getInstance($r, -256);
$this->assertSame(0, $x->compare($x2));
}
}
} }