From 79f925e43c0b9872d53658081ab5d4b18b5ab5be Mon Sep 17 00:00:00 2001 From: terrafrost Date: Tue, 28 May 2019 08:52:53 -0500 Subject: [PATCH] SFTP: replace user_error() with Exceptions --- phpseclib/Net/SFTP.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/phpseclib/Net/SFTP.php b/phpseclib/Net/SFTP.php index 60b90caa..8e1287fe 100644 --- a/phpseclib/Net/SFTP.php +++ b/phpseclib/Net/SFTP.php @@ -2468,8 +2468,8 @@ class SFTP extends SSH2 case NET_SFTP_STATUS: // presumably SSH_FX_NO_SUCH_FILE or SSH_FX_PERMISSION_DENIED return false; default: - user_error('Expected SSH_FXP_HANDLE or SSH_FXP_STATUS'); - return false; + throw new \UnexpectedValueException('Expected SSH_FXP_HANDLE or SSH_FXP_STATUS. ' + . 'Got packet type: ' . $this->packet_type); } } @@ -2923,8 +2923,7 @@ class SFTP extends SSH2 // 256 * 1024 is what SFTP_MAX_MSG_LENGTH is set to in OpenSSH's sftp-common.h if ($tempLength > 256 * 1024) { - user_error('Invalid SFTP packet size'); - return false; + throw new \RuntimeException('Invalid Size'); } // SFTP packet type and data payload