octoleo/phpseclib
1
0
Fork 0
mirror of https://github.com/phpseclib/phpseclib.git synced 2024-12-26 11:37:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

RSA: don't attempt to use the CRT when zero value components exist

Browse Source
This commit is contained in:
terrafrost 2016-05-09 13:44:48 -05:00
parent b8f3a76632
commit 942d194d0a
2 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
phpseclib/Crypt/RSA.php
View File

@ -2163,8 +2163,14 @@ class Crypt_RSA
*/ */
function _exponentiate($x) function _exponentiate($x)
{ {
if (empty($this->primes) || empty($this->coefficients) || empty($this->exponents)) { switch (true) {
return $x->modPow($this->exponent, $this->modulus); case empty($this->primes):
case $this->primes[1]->equals($this->zero):
case empty($this->coefficients):
case $this->coefficients[2]->equals($this->zero):
case empty($this->exponents):
case $this->exponents[1]->equals($this->zero):
return $x->modPow($this->exponent, $this->modulus);
} }
$num_primes = count($this->primes); $num_primes = count($this->primes);

21
tests/Unit/Crypt/RSA/LoadKeyTest.php
View File

@ -379,4 +379,25 @@ Private-MAC: 35134b7434bf828b21404099861d455e660e8740';
$rsa->setPrivateKey(); $rsa->setPrivateKey();
$rsa->loadKey($rsa); $rsa->loadKey($rsa);
} }
/**
* @group github980
*/
public function testZeroComponents()
{
$key = '-----BEGIN RSA PRIVATE KEY-----
MIGaAgEAAkEAt5yrcHAAjhglnCEn6yecMWPeUXcMyo0+itXrLlkpcKIIyqPw546b
GThhlb1ppX1ySX/OUA4jSakHekNP5eWPawIBAAJAW6/aVD05qbsZHMvZuS2Aa5Fp
NNj0BDlf38hOtkhDzz/hkYb+EBYLLvldhgsD0OvRNy8yhz7EjaUqLCB0juIN4QIB
AAIBAAIBAAIBAAIBAA==
-----END RSA PRIVATE KEY-----';
$rsa = new Crypt_RSA();
$rsa->loadKey($key);
$rsa->setSignatureMode(CRYPT_RSA_SIGNATURE_PKCS1);
$rsa->setHash('md5');
$rsa->setMGFHash('md5');
$rsa->sign('zzzz');
}
} }