octoleo
/
phpseclib
mirror of https://github.com/phpseclib/phpseclib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BigInteger: optimize getLength()

This commit is contained in:
terrafrost 2024-02-24 13:41:06 -06:00
parent c114503b5d
commit a922309855
3 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
phpseclib/Math/BigInteger/Engines/Engine.php
View File

@ -619,7 +619,7 @@ abstract class Engine implements \JsonSerializable
*/
public function getLengthInBytes()
{
return strlen($this->toBytes());
return (int) ceil($this->getLength() / 8);
}
/**

13
phpseclib/Math/BigInteger/Engines/PHP.php
View File

@ -1341,4 +1341,17 @@ abstract class PHP extends Engine
}
return false;
}
/**
* Return the size of a BigInteger in bits
*
* @return int
*/
public function getLength()
{
$max = count($this->value) - 1;
return $max != -1 ?
$max * static::BASE + intval(ceil(log($this->value[$max] + 1, 2))) :
0;
}
}

5
tests/Unit/File/ASN1Test.php
View File

@ -455,9 +455,8 @@ class ASN1Test extends PhpseclibTestCase
{
$cert = file_get_contents(dirname(__FILE__) . '/ASN1/mal-cert-02.der');
$asn1 = new ASN1();
$decoded = $asn1->decodeBER($cert);
$this->assertFalse($decoded[0]);
$decoded = ASN1::decodeBER($cert);
$this->assertNull($decoded);
//$x509 = new X509();
//$x509->loadX509($cert);