octoleo/phpseclib
1
0
Fork 0
mirror of https://github.com/phpseclib/phpseclib.git synced 2024-12-27 03:42:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove error suppression from stream_select()

Browse Source 
Suppressing errors from stream_select() makes debugging timeouts extremely hard.
This commit is contained in:
Tom Sommer 2020-01-10 11:58:36 +01:00 committed by GitHub
parent 61ffe1a147
commit e2841212cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
phpseclib/Net/SSH2.php
View File

@ -1245,7 +1245,7 @@ class SSH2
$usec = 1000000 * ($this->curTimeout - $sec); $usec = 1000000 * ($this->curTimeout - $sec);
// on windows this returns a "Warning: Invalid CRT parameters detected" error // on windows this returns a "Warning: Invalid CRT parameters detected" error
// the !count() is done as a workaround for <https://bugs.php.net/42682> // the !count() is done as a workaround for <https://bugs.php.net/42682>
if (!@stream_select($read, $write, $except, $sec, $usec) && !count($read)) { if (stream_select($read, $write, $except, $sec, $usec) === false && !count($read)) {
$this->is_timeout = true; $this->is_timeout = true;
return false; return false;
} }