none of the other statically defined variables have the potential
to change as multiple Net_SSH2 objects are created but this one does.
ie. if you connect to one SSH-2.0-SSHD server then no subsequent server
will use hmac-sha1-96 even if it could
CRYPT_RSA_PUBLIC_FORMAT_PKCS1_RAW and CRYPT_RSA_PUBLIC_FORMAT_PKCS1
produce two very similar looking keys but they are not the same.
As dissection OpenSSL's asn1parse would reveal CRYPT_RSA_PUBLIC_FORMAT_PKCS1
has the fact that it is an RSA key embedded within it whereas
CRYPT_RSA_PUBLIC_FORMAT_PKCS1_RAW does not. phpseclib now resolves
this ambiguity in the same way that OpenSSH's ssh-keygen does.
Despite this change CRYPT_RSA_PUBLIC_FORMAT_PKCS1_RAW is still incompatible
with OpenSSL's rsautl (CRYPT_RSA_PUBLIC_FORMAT_PKCS1 is compatible). I guess
this incompatibility isn't just due to the headers but is also due to the
overall structure of the format.
* master:
SFTP: update one last comment
SFTP: update unit test comments
SFTP: add new line to end of unit test
SFTP: assertEquals -> assertSame
SFTP: reset sort options every time and update unit test
SFTP: rm whitespace
SFTP: define $sortOptions
SFTP: add the ability for nlist() and rawlist() to be sorted
SFTP: add the ability for nlist() and rawlist() to be sorted
* terrafrost/sftp-sort2:
SFTP: update one last comment
SFTP: update unit test comments
SFTP: add new line to end of unit test
SFTP: assertEquals -> assertSame
SFTP: reset sort options every time and update unit test
SFTP: rm whitespace
SFTP: define $sortOptions
SFTP: add the ability for nlist() and rawlist() to be sorted
* master:
X509: Unit test CS changes
X509: move location of SPKAC unit test
X509: CS adjustments
X509: PHP4 compat changes
RSA: PHP4 compat changes
X509: rm trailing white space from unit test
X509: add SPKAC unit test
X509: add signSPKAC() and saveSPKAC() methods
X509: add signSPKAC() and saveSPKAC() methods
* terrafrost/spkac:
X509: Unit test CS changes
X509: move location of SPKAC unit test
X509: CS adjustments
X509: PHP4 compat changes
RSA: PHP4 compat changes
X509: rm trailing white space from unit test
X509: add SPKAC unit test
X509: add signSPKAC() and saveSPKAC() methods
Namespacify BigInteger
* bantu/namespacify-biginteger:
Correct the remaining case by using instanceof.
Update users of Math_BigInteger.
Some more documentation polishing in Math/BigInteger.php.
Adjust test cases using Math_BigInteger.
Replace new Math_BigInteger with new static.
Reference to instances as BigInteger instead of Math_BigInteger.
Use namespace in example code.
Remove any include statement.
Add namespace statement. Rename class.
Use __construct.
Add PSR4 namespace to composer.json.
[php5] Use composer autoloader in test bootstrap.
* bantu/tests-composer-autoloader-php5:
PHP 5.3+: Replace custom autoloader with composer autoloader.
Scrutinizer CI code coverage
* bantu/scrutinizer-coverage:
Specify the runs option for external code coverage.
No Scrutinizer Code Coverage on HHVM either.
Extract into upload-code-coverage-scrutinizer.sh
Add -html suffix to existing code-coverage shell script.
Configure Scrutinizer CI to expect external code coverage data.
Upload clover.xml from Travis CI into Scrutinizer CI.
Produce a clover.xml code coverage file.
* master:
Specify the runs option for external code coverage.
No Scrutinizer Code Coverage on HHVM either.
Extract into upload-code-coverage-scrutinizer.sh
Add -html suffix to existing code-coverage shell script.
Configure Scrutinizer CI to expect external code coverage data.
Upload clover.xml from Travis CI into Scrutinizer CI.
Produce a clover.xml code coverage file.