octoleo/plantuml
1
0
Fork 0
mirror of https://github.com/octoleo/plantuml.git synced 2024-12-22 10:59:01 +00:00
Code Issues Releases Wiki Activity

fix: improve minor issues in Gantt

Browse Source
This commit is contained in:
Arnaud Roques 2023-09-28 00:16:33 +02:00
parent 55598085f5
commit 870d09d272
5 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/net/sourceforge/plantuml/project/GanttDiagram.java
View File

@ -662,7 +662,7 @@ public class GanttDiagram extends TitledDiagram implements ToTaskDraw, WithSprit
return colorSet; return colorSet;
} }
public void setStartingDate(Day start) { public void setProjectStartingDate(Day start) {
openClose.setStartingDay(start); openClose.setStartingDay(start);
this.min = start; this.min = start;
} }

8
src/net/sourceforge/plantuml/project/lang/SentenceTaskEndsAbsolute.java
View File

@ -50,11 +50,11 @@ public class SentenceTaskEndsAbsolute extends SentenceSimple {
public CommandExecutionResult execute(GanttDiagram project, Object subject, Object complement) { public CommandExecutionResult execute(GanttDiagram project, Object subject, Object complement) {
final Task task = (Task) subject; final Task task = (Task) subject;
final Day end = (Day) complement; final Day end = (Day) complement;
// final Day startingDate = project.getStartingDate(); final Day startingDate = project.getStartingDate();
// if (startingDate == null) { if (startingDate.getAbsoluteDayNum() == 0)
// return CommandExecutionResult.error("No starting date for the project"); return CommandExecutionResult.error("No starting date for the project");
// }
task.setEnd(end); task.setEnd(end);
return CommandExecutionResult.ok(); return CommandExecutionResult.ok();
} }

4
src/net/sourceforge/plantuml/project/lang/SentenceTaskStarts.java
View File

@ -56,10 +56,10 @@ public class SentenceTaskStarts extends SentenceSimple {
HColor color = null; HColor color = null;
when = (TaskInstant) complement; when = (TaskInstant) complement;
task.setStart(when.getInstantPrecise()); task.setStart(when.getInstantPrecise());
if (when.isTask()) { if (when.isTask())
project.addContraint(new GanttConstraint(project.getIHtmlColorSet(), project.getCurrentStyleBuilder(), when, project.addContraint(new GanttConstraint(project.getIHtmlColorSet(), project.getCurrentStyleBuilder(), when,
new TaskInstant(task, TaskAttribute.START), color)); new TaskInstant(task, TaskAttribute.START), color));
}
return CommandExecutionResult.ok(); return CommandExecutionResult.ok();
}; };

8
src/net/sourceforge/plantuml/project/lang/SentenceTaskStartsAbsolute.java
View File

@ -50,10 +50,10 @@ public class SentenceTaskStartsAbsolute extends SentenceSimple {
public CommandExecutionResult execute(GanttDiagram project, Object subject, Object complement) { public CommandExecutionResult execute(GanttDiagram project, Object subject, Object complement) {
final Task task = (Task) subject; final Task task = (Task) subject;
final Day start = (Day) complement; final Day start = (Day) complement;
// final Day startingDate = project.getStartingDate(); final Day startingDate = project.getStartingDate();
// if (startingDate == null) { if (startingDate.getAbsoluteDayNum() == 0)
// return CommandExecutionResult.error("No starting date for the project"); project.setProjectStartingDate(start);
// }
task.setStart(start); task.setStart(start);
return CommandExecutionResult.ok(); return CommandExecutionResult.ok();
} }

2
src/net/sourceforge/plantuml/project/lang/SubjectProject.java
View File

@ -75,7 +75,7 @@ public class SubjectProject implements Subject {
public CommandExecutionResult execute(GanttDiagram project, Object subject, Object complement) { public CommandExecutionResult execute(GanttDiagram project, Object subject, Object complement) {
final Day start = (Day) complement; final Day start = (Day) complement;
assert project == subject; assert project == subject;
project.setStartingDate(start); project.setProjectStartingDate(start);
return CommandExecutionResult.ok(); return CommandExecutionResult.ok();
} }