octoleo/qpdf
2
1
Fork 0
mirror of https://github.com/qpdf/qpdf.git synced 2025-02-02 11:58:25 +00:00
Code Issues Releases Wiki Activity

Improve handling of replacing stream data with empty strings

Browse Source 
When an empty string was passed to replaceStreamData, the code was
passing a null pointer to memcpy. Since a 0 size was also passed, this
was harmless, but it triggers sanitizer errors. The code properly
handles a null pointer as the buffer in other places.
This commit is contained in:
Jay Berkenbilt 2022-05-16 11:07:26 -04:00
parent 60ec94a7c3
commit 051ae7c282
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libqpdf/QPDFObjectHandle.cc
View File

@ -1468,7 +1468,9 @@ QPDFObjectHandle::replaceStreamData(
assertStream(); assertStream();
auto b = std::make_shared<Buffer>(data.length()); auto b = std::make_shared<Buffer>(data.length());
unsigned char* bp = b->getBuffer(); unsigned char* bp = b->getBuffer();
memcpy(bp, data.c_str(), data.length()); if (bp) {
memcpy(bp, data.c_str(), data.length());
}
dynamic_cast<QPDF_Stream*>(obj.get())->replaceStreamData( dynamic_cast<QPDF_Stream*>(obj.get())->replaceStreamData(
b, filter, decode_parms); b, filter, decode_parms);
} }