octoleo/qpdf
2
1
Fork 0
mirror of https://github.com/qpdf/qpdf.git synced 2024-05-30 17:00:51 +00:00
Code Issues Releases Wiki Activity

Improve efficiency of number to string conversion

Browse Source
This commit is contained in:
Jay Berkenbilt 2020-10-27 11:42:09 -04:00
parent bcea54fcaa
commit 09bd1fafb1
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
libqpdf/QUtil.cc
View File

@ -267,16 +267,26 @@ int_to_string_base_internal(T num, int base, int length)
throw std::logic_error(
"int_to_string_base called with unsupported base");
}
std::ostringstream buf;
buf.imbue(std::locale::classic());
buf << std::setbase(base) << std::nouppercase << num;
std::string cvt;
if (base == 10)
{
// Use the more efficient std::to_string when possible
cvt = std::to_string(num);
}
else
{
std::ostringstream buf;
buf.imbue(std::locale::classic());
buf << std::setbase(base) << std::nouppercase << num;
cvt = buf.str();
}
std::string result;
int str_length = QIntC::to_int(buf.str().length());
int str_length = QIntC::to_int(cvt.length());
if ((length > 0) && (str_length < length))
{
result.append(QIntC::to_size(length - str_length), '0');
}
result += buf.str();
result += cvt;
if ((length < 0) && (str_length < -length))
{
result.append(QIntC::to_size(-length - str_length), ' ');