octoleo/qpdf
2
1
Fork 0
mirror of https://github.com/qpdf/qpdf.git synced 2024-12-22 10:58:58 +00:00
Code Issues Releases Wiki Activity

Fix comment formatting and update notes

Browse Source
This commit is contained in:
Jay Berkenbilt 2023-12-27 14:07:38 -05:00
parent d96f74ae34
commit 1ad6451e8c
4 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
TODO-pages.md
View File

@ -70,6 +70,7 @@ Here are some examples.
* Center the smaller page horizontally and bottom-align the trim boxes * Center the smaller page horizontally and bottom-align the trim boxes
* Generalized overlay/underlay allowing n pages in a given order with transformations. * Generalized overlay/underlay allowing n pages in a given order with transformations.
* n-up -- application of generalized overlay/underlay * n-up -- application of generalized overlay/underlay
* make one long page with an arbitrary number of pages one after the other (#546)
It should be possible to represent all of the existing qpdf operations using the above framework. It would be good to re-implement all of them in terms of this framework to exercise it. We will have to look through all the command-line arguments and make sure. Of course also make sure suggestions from issues can be implemented or at least supported by adding new selectors. It should be possible to represent all of the existing qpdf operations using the above framework. It would be good to re-implement all of them in terms of this framework to exercise it. We will have to look through all the command-line arguments and make sure. Of course also make sure suggestions from issues can be implemented or at least supported by adding new selectors.
@ -139,6 +140,7 @@ Easier to parse but yuck:
# To-do list # To-do list
* Go through all issues marked with the `pages` label and ensure that any ideas are represented here. Keep a list with mappings back to the issue number. * Go through all issues marked with the `pages` label and ensure that any ideas are represented here. Keep a list with mappings back to the issue number.
* gh search issues label:pages --repo qpdf/qpdf --limit 200 --state=open
* When ready, open a discussion ticket. * When ready, open a discussion ticket.
* Flesh out an implementation plan. * Flesh out an implementation plan.

1
TODO.md
View File

@ -47,6 +47,7 @@ Next
cleaned up. See also issue #22. cleaned up. See also issue #22.
* Make it possible to see incremental updates in qdf mode. * Make it possible to see incremental updates in qdf mode.
* Make it possible to add incremental updates. * Make it possible to add incremental updates.
* We may want a writing mode that preserves object IDs. See #339.
Possible future JSON enhancements Possible future JSON enhancements
================================= =================================

6
include/qpdf/QPDFAcroFormDocumentHelper.hh
View File

@ -27,8 +27,8 @@
// not form XObjects. // not form XObjects.
// //
// * Interactive forms are discussed in the PDF Specification (ISO PDF 32000-1:2008) section 12.7. // * Interactive forms are discussed in the PDF Specification (ISO PDF 32000-1:2008) section 12.7.
// Also relevant is the section about Widget annotations. Annotations are discussed in // Also relevant is the section about Widget annotations. Annotations are discussed in section
// section 12.5 with annotation dictionaries discussed in 12.5.1. Widget annotations are discussed // 12.5 with annotation dictionaries discussed in 12.5.1. Widget annotations are discussed
// specifically in section 12.5.6.19. // specifically in section 12.5.6.19.
// //
// * What you need to know about the structure of interactive forms in PDF files: // * What you need to know about the structure of interactive forms in PDF files:
@ -182,7 +182,7 @@ class QPDFAcroFormDocumentHelper: public QPDFDocumentHelper
// to the document or pages. You have to do that yourself after calling transformAnnotations. If // to the document or pages. You have to do that yourself after calling transformAnnotations. If
// this operation will leave orphaned fields behind, such as if you are replacing the old // this operation will leave orphaned fields behind, such as if you are replacing the old
// annotations with the new ones on the same page and the fields and annotations are not shared, // annotations with the new ones on the same page and the fields and annotations are not shared,
// you will also need to remove the old fields to prevent them from hanging round unreferenced. // you will also need to remove the old fields to prevent them from hanging around unreferenced.
QPDF_DLL QPDF_DLL
void transformAnnotations( void transformAnnotations(
QPDFObjectHandle old_annots, QPDFObjectHandle old_annots,

2
libqpdf/QPDFAnnotationObjectHelper.cc
View File

@ -171,7 +171,7 @@ QPDFAnnotationObjectHelper::getPageContentForAppearance(
QPDFObjectHandle::Rectangle rect = rect_obj.getArrayAsRectangle(); QPDFObjectHandle::Rectangle rect = rect_obj.getArrayAsRectangle();
bool do_rotate = (rotate && (flags & an_no_rotate)); bool do_rotate = (rotate && (flags & an_no_rotate));
if (do_rotate) { if (do_rotate) {
// If the the annotation flags include the NoRotate bit and the page is rotated, we have to // If the annotation flags include the NoRotate bit and the page is rotated, we have to
// rotate the annotation about its upper left corner by the same amount in the opposite // rotate the annotation about its upper left corner by the same amount in the opposite
// direction so that it will remain upright in absolute coordinates. Since the semantics of // direction so that it will remain upright in absolute coordinates. Since the semantics of
// /Rotate for a page are to rotate the page, while the effect of rotating using a // /Rotate for a page are to rotate the page, while the effect of rotating using a