From 212812d8372d01362252bf2ac189c15367ff4f5c Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Sun, 7 Jul 2013 15:35:00 -0400 Subject: [PATCH] Fix errors reported by Coverity Thanks to Jiri Popelka from Red Hat for sending the output of a Coverity run over qpdf. --- libqpdf/QPDFObjectHandle.cc | 1 + libqpdf/QPDFWriter.cc | 3 ++- libtests/flate.cc | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libqpdf/QPDFObjectHandle.cc b/libqpdf/QPDFObjectHandle.cc index 9a1aae4a..442678fd 100644 --- a/libqpdf/QPDFObjectHandle.cc +++ b/libqpdf/QPDFObjectHandle.cc @@ -35,6 +35,7 @@ QPDFObjectHandle::ParserCallbacks::terminateParsing() QPDFObjectHandle::QPDFObjectHandle() : initialized(false), + qpdf(0), objid(0), generation(0), reserved(false) diff --git a/libqpdf/QPDFWriter.cc b/libqpdf/QPDFWriter.cc index 8d169f3b..499129b1 100644 --- a/libqpdf/QPDFWriter.cc +++ b/libqpdf/QPDFWriter.cc @@ -70,6 +70,7 @@ QPDFWriter::init() encryption_V = 0; encryption_R = 0; encryption_dict_objid = 0; + pipeline = 0; next_objid = 1; cur_stream_length_id = 0; cur_stream_length = 0; @@ -2695,7 +2696,7 @@ QPDFWriter::writeLinearized() this->next_objid = part4_first_obj; enqueuePart(part4); - assert(this->next_objid = after_part4); + assert(this->next_objid == after_part4); this->next_objid = part6_first_obj; enqueuePart(part6); assert(this->next_objid == after_part6); diff --git a/libtests/flate.cc b/libtests/flate.cc index a6d4eeb6..3da056ed 100644 --- a/libtests/flate.cc +++ b/libtests/flate.cc @@ -46,6 +46,7 @@ void run(char const* filename) // Write to the both pipeline def3->write(buf, len); } + fclose(in1); def1->finish(); delete def1; @@ -69,6 +70,7 @@ void run(char const* filename) { inf2->write(buf, len); } + fclose(in2); inf2->finish(); delete inf2;