octoleo
/
qpdf
mirror of https://github.com/qpdf/qpdf.git
2
1
Fork 0
Code Issues Releases Wiki Activity

Add a blank line after the first header included in each source

This commit is contained in:
Jay Berkenbilt 2022-02-04 16:31:31 -05:00
parent 2abb305565
commit 2229e37e88
63 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
README-maintainer
View File

@ -86,6 +86,15 @@ GOOGLE OSS-FUZZ
CODING RULES
* In a source file, include the header file that declares the source
class first followed by a blank line. If a config file is needed
first, put a blank line between that and the header followed by
another blank line. This assures that each header file is included
first at least once, thereby ensuring that it explicitly includes
all the headers it needs, which in turn alleviates lots of header
ordering problems. The blank line ensures that formatters don't
messt his up by resorting the headers.
* Avoid atoi. Use QUtil::string_to_int instead. It does
overflow/underflow checking.

1
libqpdf/AES_PDF_native.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/AES_PDF_native.hh>
#include <qpdf/QUtil.hh>
#include <cstring>
#include <assert.h>

1
libqpdf/BitStream.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/BitStream.hh>
#include <qpdf/QIntC.hh>
// See comments in bits.cc

1
libqpdf/BufferInputSource.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/BufferInputSource.hh>
#include <qpdf/QIntC.hh>
#include <string.h>
#include <stdexcept>

1
libqpdf/ClosedFileInputSource.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/ClosedFileInputSource.hh>
#include <qpdf/FileInputSource.hh>
ClosedFileInputSource::Members::Members(char const* filename) :

1
libqpdf/ContentNormalizer.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/ContentNormalizer.hh>
#include <qpdf/QUtil.hh>
ContentNormalizer::ContentNormalizer() :

1
libqpdf/CryptoRandomDataProvider.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/CryptoRandomDataProvider.hh>
#include <qpdf/QPDFCryptoProvider.hh>
CryptoRandomDataProvider::CryptoRandomDataProvider()

1
libqpdf/FileInputSource.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/FileInputSource.hh>
#include <string.h>
#include <qpdf/QUtil.hh>
#include <qpdf/QPDFExc.hh>

1
libqpdf/InputSource.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/InputSource.hh>
#include <string.h>
#include <stdexcept>
#include <qpdf/QTC.hh>

1
libqpdf/JSON.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/JSON.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/QTC.hh>
#include <stdexcept>

1
libqpdf/JSONHandler.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/JSONHandler.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/QTC.hh>
#include <qpdf/QPDFUsage.hh>

1
libqpdf/MD5.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/MD5.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/QIntC.hh>
#include <qpdf/QPDFCryptoProvider.hh>

1
libqpdf/MD5_native.cc
View File

@ -28,6 +28,7 @@
/////////////////////////////////////////////////////////////////////////
#include <qpdf/MD5_native.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/QIntC.hh>

1
libqpdf/NNTree.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/NNTree.hh>
#include <qpdf/QTC.hh>
#include <qpdf/QUtil.hh>

1
libqpdf/OffsetInputSource.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/OffsetInputSource.hh>
#include <limits>
#include <sstream>
#include <stdexcept>

1
libqpdf/Pipeline.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pipeline.hh>
#include <stdexcept>
Pipeline::Pipeline(char const* identifier, Pipeline* next) :

1
libqpdf/Pl_AES_PDF.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_AES_PDF.hh>
#include <qpdf/QUtil.hh>
#include <cstring>
#include <assert.h>

1
libqpdf/Pl_ASCII85Decoder.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_ASCII85Decoder.hh>
#include <qpdf/QTC.hh>
#include <stdexcept>
#include <string.h>

1
libqpdf/Pl_ASCIIHexDecoder.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_ASCIIHexDecoder.hh>
#include <qpdf/QTC.hh>
#include <stdexcept>
#include <string.h>

1
libqpdf/Pl_Buffer.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_Buffer.hh>
#include <stdexcept>
#include <algorithm>
#include <assert.h>

1
libqpdf/Pl_Count.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_Count.hh>
#include <qpdf/QIntC.hh>
Pl_Count::Members::Members() :

1
libqpdf/Pl_Flate.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_Flate.hh>
#include <zlib.h>
#include <string.h>
#include <limits.h>

1
libqpdf/Pl_MD5.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_MD5.hh>
#include <stdexcept>
Pl_MD5::Pl_MD5(char const* identifier, Pipeline* next) :

1
libqpdf/Pl_PNGFilter.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_PNGFilter.hh>
#include <qpdf/QTC.hh>
#include <stdexcept>
#include <string.h>

1
libqpdf/Pl_QPDFTokenizer.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_QPDFTokenizer.hh>
#include <qpdf/QTC.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/BufferInputSource.hh>

1
libqpdf/Pl_RC4.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_RC4.hh>
#include <qpdf/QUtil.hh>
Pl_RC4::Pl_RC4(char const* identifier, Pipeline* next,

1
libqpdf/Pl_SHA2.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_SHA2.hh>
#include <stdexcept>
#include <cstdio>
#include <qpdf/PointerHolder.hh>

2
libqpdf/Pl_StdioFile.cc
View File

@ -1,5 +1,7 @@
#include <qpdf/qpdf-config.h> // include first for large file support
#include <qpdf/Pl_StdioFile.hh>
#include <qpdf/QUtil.hh>
#include <stdexcept>
#include <errno.h>

1
libqpdf/Pl_TIFFPredictor.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/Pl_TIFFPredictor.hh>
#include <qpdf/QTC.hh>
#include <qpdf/BitStream.hh>
#include <qpdf/BitWriter.hh>

1
libqpdf/QPDF.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/qpdf-config.h> // include first for large file support
#include <qpdf/QPDF.hh>
#include <atomic>

1
libqpdf/QPDFAnnotationObjectHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFAnnotationObjectHelper.hh>
#include <qpdf/QTC.hh>
#include <qpdf/QPDFMatrix.hh>
#include <qpdf/QUtil.hh>

1
libqpdf/QPDFArgParser.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFArgParser.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/QIntC.hh>
#include <qpdf/QTC.hh>

1
libqpdf/QPDFCryptoProvider.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFCryptoProvider.hh>
#include <qpdf/qpdf-config.h>
#include <qpdf/QUtil.hh>
#include <stdexcept>

1
libqpdf/QPDFCrypto_gnutls.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFCrypto_gnutls.hh>
#include <qpdf/QIntC.hh>
#include <qpdf/QUtil.hh>
#include <cstring>

1
libqpdf/QPDFCrypto_native.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFCrypto_native.hh>
#include <qpdf/QUtil.hh>
#ifdef USE_INSECURE_RANDOM

1
libqpdf/QPDFEFStreamObjectHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFEFStreamObjectHelper.hh>
#include <qpdf/QIntC.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/Pl_Count.hh>

1
libqpdf/QPDFExc.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFExc.hh>
#include <qpdf/QUtil.hh>
QPDFExc::QPDFExc(qpdf_error_code_e error_code,

1
libqpdf/QPDFFileSpecObjectHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFFileSpecObjectHelper.hh>
#include <qpdf/QTC.hh>
#include <qpdf/QPDF.hh>
#include <qpdf/QUtil.hh>

1
libqpdf/QPDFFormFieldObjectHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFFormFieldObjectHelper.hh>
#include <qpdf/QTC.hh>
#include <qpdf/QPDFAcroFormDocumentHelper.hh>
#include <qpdf/QPDFAnnotationObjectHelper.hh>

2
libqpdf/QPDFJob_argv.cc
View File

@ -115,6 +115,7 @@ ArgParser::argVersion()
void
ArgParser::argCopyright()
{
// clang-format off
// Make sure the output looks right on an 80-column display.
// 1 2 3 4 5 6 7 8
// 12345678901234567890123456789012345678901234567890123456789012345678901234567890
@ -153,6 +154,7 @@ ArgParser::argCopyright()
<< std::endl
<< "see the manual for additional information."
<< std::endl;
// clang-format on
}
void

1
libqpdf/QPDFJob_config.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFJob.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/QTC.hh>

1
libqpdf/QPDFJob_json.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFJob.hh>
#include <qpdf/JSONHandler.hh>
#include <qpdf/QPDFUsage.hh>
#include <qpdf/QUtil.hh>

1
libqpdf/QPDFMatrix.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFMatrix.hh>
#include <qpdf/QUtil.hh>
#include <algorithm>

1
libqpdf/QPDFNameTreeObjectHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFNameTreeObjectHelper.hh>
#include <qpdf/NNTree.hh>
class NameTreeDetails: public NNTreeDetails

1
libqpdf/QPDFNumberTreeObjectHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFNumberTreeObjectHelper.hh>
#include <qpdf/NNTree.hh>
#include <qpdf/QIntC.hh>

1
libqpdf/QPDFObjGen.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFObjGen.hh>
#include <qpdf/QUtil.hh>
QPDFObjGen::QPDFObjGen() :

1
libqpdf/QPDFOutlineDocumentHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFOutlineDocumentHelper.hh>
#include <qpdf/QTC.hh>
QPDFOutlineDocumentHelper::Members::~Members()

1
libqpdf/QPDFOutlineObjectHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFOutlineObjectHelper.hh>
#include <qpdf/QPDFOutlineDocumentHelper.hh>
#include <qpdf/QTC.hh>

1
libqpdf/QPDFPageDocumentHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFPageDocumentHelper.hh>
#include <qpdf/QPDFAcroFormDocumentHelper.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/QTC.hh>

1
libqpdf/QPDFPageLabelDocumentHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFPageLabelDocumentHelper.hh>
#include <qpdf/QTC.hh>
QPDFPageLabelDocumentHelper::Members::~Members()

1
libqpdf/QPDFPageObjectHelper.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFPageObjectHelper.hh>
#include <qpdf/QTC.hh>
#include <qpdf/QPDF.hh>
#include <qpdf/Pl_Concatenate.hh>

1
libqpdf/QPDFSystemError.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFSystemError.hh>
#include <qpdf/QUtil.hh>
#include <string.h>

1
libqpdf/QPDFWriter.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/qpdf-config.h> // include first for large file support
#include <qpdf/QPDFWriter.hh>
#include <assert.h>

1
libqpdf/QPDFXRefEntry.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDFXRefEntry.hh>
#include <qpdf/QPDFExc.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/QIntC.hh>

1
libqpdf/QPDF_Array.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDF_Array.hh>
#include <qpdf/QUtil.hh>
#include <qpdf/QIntC.hh>
#include <stdexcept>

1
libqpdf/QPDF_Reserved.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/QPDF_Reserved.hh>
#include <stdexcept>
QPDF_Reserved::~QPDF_Reserved()

1
libqpdf/QUtil.cc
View File

@ -2,6 +2,7 @@
#include <qpdf/qpdf-config.h>
#include <qpdf/QUtil.hh>
#include <qpdf/PointerHolder.hh>
#include <qpdf/CryptoRandomDataProvider.hh>
#include <qpdf/QPDFSystemError.hh>

1
libqpdf/RC4.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/RC4.hh>
#include <qpdf/QPDFCryptoProvider.hh>
#include <string.h>

1
libqpdf/RC4_native.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/RC4_native.hh>
#include <qpdf/QIntC.hh>
#include <string.h>

1
libqpdf/SF_FlateLzwDecode.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/SF_FlateLzwDecode.hh>
#include <qpdf/Pl_PNGFilter.hh>
#include <qpdf/Pl_TIFFPredictor.hh>
#include <qpdf/Pl_Flate.hh>

1
libqpdf/SHA2_native.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/SHA2_native.hh>
#include <stdexcept>
#include <cstdio>
#include <qpdf/PointerHolder.hh>

1
libqpdf/SparseOHArray.cc
View File

@ -1,4 +1,5 @@
#include <qpdf/SparseOHArray.hh>
#include <stdexcept>
SparseOHArray::SparseOHArray() :

1
libqpdf/qpdf-c.cc
View File

@ -1,6 +1,7 @@
#include <qpdf/qpdf-c.h>
#include <qpdf/QPDF.hh>
#include <qpdf/QPDFWriter.hh>
#include <qpdf/QTC.hh>
#include <qpdf/QPDFExc.hh>