octoleo/qpdf
2
1
Fork 0
mirror of https://github.com/qpdf/qpdf.git synced 2024-12-22 10:58:58 +00:00
Code Issues Releases Wiki Activity

Merge pull request #1070 from m-holger/flate

Browse Source 
Change default for SF_FlateLzwDecode::columns to 1
This commit is contained in:
Jay Berkenbilt 2023-12-16 11:50:17 -05:00 committed by GitHub
commit 290742b069
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libqpdf/SF_FlateLzwDecode.cc
View File

@ -11,7 +11,7 @@ SF_FlateLzwDecode::SF_FlateLzwDecode(bool lzw) :
lzw(lzw),
// Initialize values to their defaults as per the PDF spec
predictor(1),
columns(0),
columns(1),
colors(1),
bits_per_component(8),
early_code_change(true)

BIN
qpdf/qtest/qpdf/png-filters-1-column.pdf Normal file
View File

Binary file not shown.

BIN
qpdf/qtest/qpdf/png-filters-no-columns-decoded.pdf Normal file
View File

Binary file not shown.

BIN
qpdf/qtest/qpdf/png-filters-no-columns.pdf Normal file
View File

Binary file not shown.

16
qpdf/qtest/specialized-filter.test
View File

@ -16,7 +16,7 @@ cleanup();
my $td = new TestDriver('specialized-filter');
my $n_tests = 3;
my $n_tests = 5;
my $n_compare_pdfs = 1;
# The PDF file was submitted on bug #83 on github. All the PNG filters
@ -39,6 +39,18 @@ $td->runtest("stream with tiff predictor",
{$td->FILE => "tiff-predictor.out",
$td->EXIT_STATUS => 0},
$td->NORMALIZE_NEWLINES);
# TC:SF_FlateLzwDecode PNG filter
# PDF:Table 8:Columns
# The test file is invalid as it does not actually use one column (as is implied by the missing
# key). However png-filters-1-column.pdf is the same file with /Columns explicitely set to 1,
# and displays the same as png-filters-no-columns.pdf and png-filters-no-columns-decoded.pdf.
$td->runtest("decode flate no /Columns",
{$td->COMMAND => "qpdf --static-id --compress-streams=n --decode-level=all" .
" png-filters-no-columns.pdf a.pdf"},
{$td->STRING => "", $td->EXIT_STATUS => 0},
$td->NORMALIZE_NEWLINES);
$td->runtest("check output",
{$td->FILE => "a.pdf"},
{$td->FILE => "png-filters-no-columns-decoded.pdf"});
cleanup();
$td->report(calc_ntests($n_tests, $n_compare_pdfs));