octoleo/qpdf
2
1
Fork 0
mirror of https://github.com/qpdf/qpdf.git synced 2024-06-05 03:40:53 +00:00
Code Issues Releases Wiki Activity

Avoid unnecessary string copies in QPDFParser::parse

Browse Source 
Fixes #864. QPDFTokenizer::getValue originally had a std::string_view
return type, which was changed to std::string without removing some
unnecessary string creation.
This commit is contained in:
m-holger 2023-10-27 14:07:01 +01:00
parent 81823f4032
commit 29cd8f4f53
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libqpdf/QPDFParser.cc
View File

@ -156,8 +156,7 @@ QPDFParser::parse(bool& empty, bool content_stream)
break;
case QPDFTokenizer::tt_integer:
object = QPDF_Integer::create(
QUtil::string_to_ll(std::string(tokenizer.getValue()).c_str()));
object = QPDF_Integer::create(QUtil::string_to_ll(tokenizer.getValue().c_str()));
break;
case QPDFTokenizer::tt_real:
@ -166,7 +165,7 @@ QPDFParser::parse(bool& empty, bool content_stream)
case QPDFTokenizer::tt_name:
{
auto name = tokenizer.getValue();
auto const& name = tokenizer.getValue();
object = QPDF_Name::create(name);
if (name == "/Contents") {
@ -179,7 +178,7 @@ QPDFParser::parse(bool& empty, bool content_stream)
case QPDFTokenizer::tt_word:
{
auto value = tokenizer.getValue();
auto const& value = tokenizer.getValue();
auto size = olist.size();
if (content_stream) {
object = QPDF_Operator::create(value);
@ -226,7 +225,7 @@ QPDFParser::parse(bool& empty, bool content_stream)
case QPDFTokenizer::tt_string:
{
auto val = tokenizer.getValue();
auto const& val = tokenizer.getValue();
if (decrypter) {
if (b_contents) {
frame.contents_string = val;