octoleo/qpdf
2
1
Fork 0
mirror of https://github.com/qpdf/qpdf.git synced 2025-01-03 15:17:29 +00:00
Code Issues Releases Wiki Activity

Add comments after merge of last pull request

Browse Source
This commit is contained in:
Jay Berkenbilt 2022-09-01 15:30:25 -04:00
parent f12539e8aa
commit 481b1aeb50
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libqpdf/QPDF_optimization.cc
View File

@ -142,7 +142,9 @@ QPDF::pushInheritedAttributesToPage(bool allow_changes, bool warn_skipped_keys)
return; return;
} }
// Calling getAllPages() resolves any duplicated page objects. // Calling getAllPages() resolves any duplicated page objects,
// repairs broken nodes, and detects loops, so we don't have to do
// those activities here.
getAllPages(); getAllPages();
// key_ancestors is a mapping of page attribute keys to a stack of // key_ancestors is a mapping of page attribute keys to a stack of
@ -234,7 +236,10 @@ QPDF::pushInheritedAttributesToPageInternal(
} }
} }
// Process descendant nodes. // Process descendant nodes. This method does not perform loop
// detection because all code paths that lead here follow a call
// to getAllPages, which already throws an exception in the event
// of a loop in the pages tree.
for (auto& kid: cur_pages.getKey("/Kids").aitems()) { for (auto& kid: cur_pages.getKey("/Kids").aitems()) {
if (kid.isDictionaryOfType("/Pages")) { if (kid.isDictionaryOfType("/Pages")) {
pushInheritedAttributesToPageInternal( pushInheritedAttributesToPageInternal(