octoleo/qpdf
2
1
Fork 0
mirror of https://github.com/qpdf/qpdf.git synced 2024-05-29 08:20:53 +00:00
Code Issues Releases Wiki Activity

QPDFPageObjectHelper::placeFormXObject: use std::string const& (fixes #374)

Browse Source
This commit is contained in:
Jay Berkenbilt 2020-04-03 12:03:07 -04:00
parent 97de12343b
commit 5806e5c60c
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
TODO
View File

@ -19,9 +19,6 @@ ABI Changes
This is a list of changes to make next time there is an ABI change.
Comments appear in the code prefixed by "ABI"
* QPDFPageObjectHelper::placeFormXObject: name should be std::string
const& (issue #374)
* (Source compatibility) As somewhat discussed in issue 219, the
original pipeStreamData in QPDF_Stream has various logic for
reporting warnings and letting the caller retry. This logic is not

2
include/qpdf/QPDFPageObjectHelper.hh
View File

@ -227,7 +227,7 @@ class QPDFPageObjectHelper: public QPDFObjectHelper
// examples/pdf-overlay-page.cc for an example.
QPDF_DLL
std::string placeFormXObject(
QPDFObjectHandle fo, std::string name,
QPDFObjectHandle fo, std::string const& name,
QPDFObjectHandle::Rectangle rect,
bool invert_transformations = true);

3
libqpdf/QPDFPageObjectHelper.cc
View File

@ -720,10 +720,9 @@ QPDFPageObjectHelper::getFormXObjectForPage(bool handle_transformations)
return result;
}
// ABI: name should be std:string const&
std::string
QPDFPageObjectHelper::placeFormXObject(
QPDFObjectHandle fo, std::string name,
QPDFObjectHandle fo, std::string const& name,
QPDFObjectHandle::Rectangle rect,
bool invert_transformations)
{