diff --git a/libqpdf/ClosedFileInputSource.cc b/libqpdf/ClosedFileInputSource.cc index dfb98c6a..ec977c69 100644 --- a/libqpdf/ClosedFileInputSource.cc +++ b/libqpdf/ClosedFileInputSource.cc @@ -23,7 +23,7 @@ ClosedFileInputSource::~ClosedFileInputSource() void ClosedFileInputSource::before() { - if (nullptr == this->m->fis.get()) { + if (nullptr == this->m->fis) { this->m->fis = std::make_shared(this->m->filename.c_str()); this->m->fis->seek(this->m->offset, SEEK_SET); diff --git a/libqpdf/JSON.cc b/libqpdf/JSON.cc index c825413e..07180cf5 100644 --- a/libqpdf/JSON.cc +++ b/libqpdf/JSON.cc @@ -204,7 +204,7 @@ JSON::JSON_blob::write(Pipeline* p, size_t) const void JSON::write(Pipeline* p, size_t depth) const { - if (nullptr == this->m->value.get()) { + if (nullptr == this->m->value) { *p << "null"; } else { this->m->value->write(p, depth); @@ -1122,7 +1122,7 @@ JSONParser::handleToken() break; } - if ((item.get() == nullptr) == (delimiter == '\0')) { + if ((item == nullptr) == (delimiter == '\0')) { throw std::logic_error( "JSONParser::handleToken: logic error: exactly one of item" " or delimiter must be set"); diff --git a/libqpdf/Pl_Buffer.cc b/libqpdf/Pl_Buffer.cc index c7e3f923..791656d8 100644 --- a/libqpdf/Pl_Buffer.cc +++ b/libqpdf/Pl_Buffer.cc @@ -26,7 +26,7 @@ Pl_Buffer::~Pl_Buffer() void Pl_Buffer::write(unsigned char const* buf, size_t len) { - if (this->m->data.get() == nullptr) { + if (this->m->data == nullptr) { this->m->data = std::make_shared(len); } size_t cur_size = this->m->data->getSize(); diff --git a/libqpdf/Pl_Flate.cc b/libqpdf/Pl_Flate.cc index 4183b7e4..7f2fa4a6 100644 --- a/libqpdf/Pl_Flate.cc +++ b/libqpdf/Pl_Flate.cc @@ -86,7 +86,7 @@ Pl_Flate::warn(char const* msg, int code) void Pl_Flate::write(unsigned char const* data, size_t len) { - if (this->m->outbuf.get() == nullptr) { + if (this->m->outbuf == nullptr) { throw std::logic_error( this->identifier + ": Pl_Flate: write() called after finish() called"); diff --git a/libqpdf/Pl_RC4.cc b/libqpdf/Pl_RC4.cc index 823b22ea..ba0cb201 100644 --- a/libqpdf/Pl_RC4.cc +++ b/libqpdf/Pl_RC4.cc @@ -18,7 +18,7 @@ Pl_RC4::Pl_RC4( void Pl_RC4::write(unsigned char const* data, size_t len) { - if (this->outbuf.get() == nullptr) { + if (this->outbuf == nullptr) { throw std::logic_error( this->identifier + ": Pl_RC4: write() called after finish() called"); diff --git a/libqpdf/QPDF.cc b/libqpdf/QPDF.cc index c2c764db..7e0dd11e 100644 --- a/libqpdf/QPDF.cc +++ b/libqpdf/QPDF.cc @@ -2457,7 +2457,7 @@ QPDF::copyStreamData(QPDFObjectHandle result, QPDFObjectHandle foreign) } std::shared_ptr stream_buffer = stream->getStreamDataBuffer(); if ((foreign_stream_qpdf->m->immediate_copy_from) && - (stream_buffer.get() == nullptr)) { + (stream_buffer == nullptr)) { // Pull the stream data into a buffer before attempting // the copy operation. Do it on the source stream so that // if the source stream is copied multiple times, we don't diff --git a/libqpdf/QPDFEmbeddedFileDocumentHelper.cc b/libqpdf/QPDFEmbeddedFileDocumentHelper.cc index fd706c27..030f32d3 100644 --- a/libqpdf/QPDFEmbeddedFileDocumentHelper.cc +++ b/libqpdf/QPDFEmbeddedFileDocumentHelper.cc @@ -50,7 +50,7 @@ QPDFEmbeddedFileDocumentHelper::QPDFEmbeddedFileDocumentHelper(QPDF& qpdf) : bool QPDFEmbeddedFileDocumentHelper::hasEmbeddedFiles() const { - return (this->m->embedded_files.get() != nullptr); + return (this->m->embedded_files != nullptr); } void diff --git a/libqpdf/QPDFJob.cc b/libqpdf/QPDFJob.cc index f1b35f56..f8d963b2 100644 --- a/libqpdf/QPDFJob.cc +++ b/libqpdf/QPDFJob.cc @@ -223,7 +223,7 @@ ImageOptimizer::evaluate(std::string const& description) Pl_Discard d; Pl_Count c("count", &d); std::shared_ptr p = makePipeline(description, &c); - if (p.get() == nullptr) { + if (p == nullptr) { // message issued by makePipeline return false; } @@ -252,7 +252,7 @@ void ImageOptimizer::provideStreamData(QPDFObjGen const&, Pipeline* pipeline) { std::shared_ptr p = makePipeline("", pipeline); - if (p.get() == nullptr) { + if (p == nullptr) { // Should not be possible image.warnIfPossible("unable to create pipeline after previous" " success; image data will be lost"); @@ -2243,8 +2243,7 @@ QPDFJob::handleUnderOverlay(QPDF& pdf) { validateUnderOverlay(pdf, &m->underlay); validateUnderOverlay(pdf, &m->overlay); - if ((nullptr == m->underlay.pdf.get()) && - (nullptr == m->overlay.pdf.get())) { + if ((nullptr == m->underlay.pdf) && (nullptr == m->overlay.pdf)) { return; } std::map> underlay_pagenos; diff --git a/libqpdf/QPDFObjectHandle.cc b/libqpdf/QPDFObjectHandle.cc index 135b7c39..152f1ae2 100644 --- a/libqpdf/QPDFObjectHandle.cc +++ b/libqpdf/QPDFObjectHandle.cc @@ -3122,10 +3122,10 @@ QPDFObjectHandle::dereference() QPDF::Resolver::objectChanged(this->qpdf, getObjGen(), this->obj)) { this->obj = nullptr; } - if (this->obj.get() == nullptr) { + if (this->obj == nullptr) { std::shared_ptr obj = QPDF::Resolver::resolve(this->qpdf, getObjGen()); - if (obj.get() == nullptr) { + if (obj == nullptr) { // QPDF::resolve never returns an uninitialized object, but // check just in case. this->obj = QPDF_Null::create(); diff --git a/libqpdf/QPDFOutlineDocumentHelper.cc b/libqpdf/QPDFOutlineDocumentHelper.cc index 4149ea1e..5b2f71f6 100644 --- a/libqpdf/QPDFOutlineDocumentHelper.cc +++ b/libqpdf/QPDFOutlineDocumentHelper.cc @@ -82,7 +82,7 @@ QPDFOutlineDocumentHelper::resolveNamedDest(QPDFObjectHandle name) result = this->m->dest_dict.getKey(name.getName()); } } else if (name.isString()) { - if (nullptr == this->m->names_dest.get()) { + if (nullptr == this->m->names_dest) { QPDFObjectHandle names = this->qpdf.getRoot().getKey("/Names"); if (names.isDictionary()) { QPDFObjectHandle dests = names.getKey("/Dests"); diff --git a/libqpdf/QPDFPageLabelDocumentHelper.cc b/libqpdf/QPDFPageLabelDocumentHelper.cc index 805dc40f..08a35097 100644 --- a/libqpdf/QPDFPageLabelDocumentHelper.cc +++ b/libqpdf/QPDFPageLabelDocumentHelper.cc @@ -16,7 +16,7 @@ QPDFPageLabelDocumentHelper::QPDFPageLabelDocumentHelper(QPDF& qpdf) : bool QPDFPageLabelDocumentHelper::hasPageLabels() { - return nullptr != this->m->labels.get(); + return nullptr != this->m->labels; } QPDFObjectHandle