octoleo/qpdf
2
1
Fork 0
mirror of https://github.com/qpdf/qpdf.git synced 2025-01-03 15:17:29 +00:00
Code Issues Releases Wiki Activity

Decide against adding handleWarning back to ParserCallbacks

Browse Source
This commit is contained in:
Jay Berkenbilt 2022-04-16 13:41:53 -04:00
parent 75fe4f60c3
commit 877694a583
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
TODO
View File

@ -490,11 +490,6 @@ in source and header files to find items not listed here.
oh as the new value and returns it. oh as the new value and returns it.
* Add default values to the getters, like getIntValue(default_value). * Add default values to the getters, like getIntValue(default_value).
If a default value is passed in, you never get a type warning. If a default value is passed in, you never get a type warning.
* Added QPDFObjectHandle::ParserCallbacks::handleWarning but had to
revert because it was not binary compatible. Consider re-adding. The
commit that added this comment includes the reverting of the change.
The previous commit removes the code that was calling and using
handleWarning.
* Make it easier to deal with objects that should be indirect. Search * Make it easier to deal with objects that should be indirect. Search
for makeIndirectObject in the code to find patterns. For example, it for makeIndirectObject in the code to find patterns. For example, it
would be nice to have a one-liner for the case of one or all would be nice to have a one-liner for the case of one or all