From 8eca9d8fd988d6834f3d59554277ff1d9f05d8c9 Mon Sep 17 00:00:00 2001
From: m-holger <m-holger@kubitscheck.org>
Date: Thu, 27 Jan 2022 14:03:32 +0000
Subject: [PATCH] Fix QPDFObjectHandle::isOrHasName

Ensure isOrHasName returns true if object is an array and the name is
present anywhere in the array.
---
 libqpdf/QPDFObjectHandle.cc | 18 +++++++++++++++---
 qpdf/test_driver.cc         |  9 +++++++++
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/libqpdf/QPDFObjectHandle.cc b/libqpdf/QPDFObjectHandle.cc
index f8d52a7b..e5b9a3e3 100644
--- a/libqpdf/QPDFObjectHandle.cc
+++ b/libqpdf/QPDFObjectHandle.cc
@@ -1055,9 +1055,21 @@ QPDFObjectHandle::getDictAsMap()
 bool
 QPDFObjectHandle::isOrHasName(std::string const& value)
 {
-    return isNameAndEquals(value) ||
-           (isArray() && (getArrayNItems() > 0) && 
-            getArrayItem(0).isNameAndEquals(value));
+    if (isNameAndEquals(value))
+    {
+        return true;
+    }
+    else if (isArray())
+    {
+        for (auto& item: aitems())
+        {
+            if (item.isNameAndEquals(value))
+            {
+                return true;
+            }
+        }
+    }
+    return false;
 }
 
 void
diff --git a/qpdf/test_driver.cc b/qpdf/test_driver.cc
index 796d51fb..0e5b47af 100644
--- a/qpdf/test_driver.cc
+++ b/qpdf/test_driver.cc
@@ -3128,6 +3128,15 @@ static void test_82(QPDF& pdf, char const* arg2)
     assert(stream.isStreamOfType("/ObjStm"));
     assert(! stream.isStreamOfType("/Test"));
     assert(! pdf.getObjectByID(2,0).isStreamOfType("/Pages"));
+    auto array = QPDFObjectHandle::parse("[/Blah /Blaah /Blaaah]");
+    assert(array.isOrHasName("/Blah"));
+    assert(array.isOrHasName("/Blaaah"));
+    assert(! array.isOrHasName("/Blaaaah"));
+    assert(array.getArrayItem(0).isOrHasName("/Blah"));
+    assert(! array.getArrayItem(1).isOrHasName("/Blah"));
+    array = QPDFObjectHandle::parse("[]");
+    assert(! array.isOrHasName("/Blah"));
+    assert(! str.isOrHasName("/Marvin"));
 }
 
 void runtest(int n, char const* filename1, char const* arg2)