From 95ba7125ffa4efd4022fd27ab61ff739b0864258 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Sun, 4 Feb 2018 14:01:57 -0500 Subject: [PATCH] Fix link order (fixes #176) Specify qpdf libraries before external ones. Specify LDFLAGS before libraries. This should eliminate remaining cases of qpdf builds favoring previously installed versions. --- libtests/build.mk | 2 +- make/libtool.mk | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libtests/build.mk b/libtests/build.mk index 1eebd8fb..0b895225 100644 --- a/libtests/build.mk +++ b/libtests/build.mk @@ -43,4 +43,4 @@ $(foreach B,$(BINS_libtests),$(eval \ $(foreach B,$(BINS_libtests),$(eval \ libtests/$(OUTPUT_DIR)/$(call binname,$(B)): $(OBJS_$(B)) ; \ - $(call makebin,$(OBJS_$(B)),$$@,$(LDFLAGS_libqpdf) $(LDFLAGS),$(LIBS) $(LIBS_libqpdf)))) + $(call makebin,$(OBJS_$(B)),$$@,$(LDFLAGS_libqpdf) $(LDFLAGS),$(LIBS_libqpdf) $(LIBS)))) diff --git a/make/libtool.mk b/make/libtool.mk index 98191bdd..e68bea4c 100644 --- a/make/libtool.mk +++ b/make/libtool.mk @@ -94,14 +94,14 @@ endef define makelib $(LIBTOOL) --mode=link \ $(CXX) $(CXXFLAGS) $(LD_VERSION_FLAGS) \ - -o $(2) $(1) $(4) $(3) \ + -o $(2) $(1) $(3) $(4) \ -rpath $(libdir) -version-info $(5):$(6):$(7) -no-undefined endef # 1 2 3 4 # Usage: $(call makebin,objs,binary,ldflags,libs) define makebin - $(LIBTOOL) --mode=link $(CXX) $(CXXFLAGS) $(1) -o $(2) $(4) $(3) + $(LIBTOOL) --mode=link $(CXX) $(CXXFLAGS) $(1) -o $(2) $(3) $(4) endef # Install target