Code tidy - Clang-Tidy rule modernize-use-equals-default

examples/pdf-count-strings.cc

@@ -26,9 +26,7 @@ usage()
 class StringCounter: public QPDFObjectHandle::TokenFilter
 {
   public:
-    StringCounter()
+    StringCounter() = default;
-    {
-    }
     ~StringCounter() override = default;
     void handleToken(QPDFTokenizer::Token const&) override;
     void handleEOF() override;

include/qpdf/QPDF.hh

@@ -1150,10 +1150,6 @@ class QPDF
     // PDF 1.4: Table F.4
     struct HPageOffsetEntry
     {
-        HPageOffsetEntry()
-        {
-        }
-
         int delta_nobjects{0};              // 1
         qpdf_offset_t delta_page_length{0}; // 2
         // vectors' sizes = nshared_objects
@@ -1167,10 +1163,6 @@ class QPDF
     // PDF 1.4: Table F.3
     struct HPageOffset
     {
-        HPageOffset()
-        {
-        }
-
         int min_nobjects{0};                // 1
         qpdf_offset_t first_page_offset{0}; // 2
         int nbits_delta_nobjects{0};        // 3
@@ -1191,10 +1183,6 @@ class QPDF
     // PDF 1.4: Table F.6
     struct HSharedObjectEntry
     {
-        HSharedObjectEntry()
-        {
-        }
-
         // Item 3 is a 128-bit signature (unsupported by Acrobat)
         int delta_group_length{0}; // 1
         int signature_present{0};  // 2 -- always 0
@@ -1204,10 +1192,6 @@ class QPDF
     // PDF 1.4: Table F.5
     struct HSharedObject
     {
-        HSharedObject()
-        {
-        }
-
         int first_shared_obj{0};              // 1
         qpdf_offset_t first_shared_offset{0}; // 2
         int nshared_first_page{0};            // 3
@@ -1222,10 +1206,6 @@ class QPDF
     // PDF 1.4: Table F.9
     struct HGeneric
     {
-        HGeneric()
-        {
-        }
-
         int first_object{0};                  // 1
         qpdf_offset_t first_object_offset{0}; // 2
         int nobjects{0};                      // 3
@@ -1237,10 +1217,6 @@ class QPDF
     // Initialized from Linearization Parameter dictionary
     struct LinParameters
     {
-        LinParameters()
-        {
-        }
-
         qpdf_offset_t file_size{0};        // /L
         int first_page_object{0};          // /O
         qpdf_offset_t first_page_end{0};   // /E
@@ -1264,10 +1240,6 @@ class QPDF
 
     struct CHPageOffsetEntry
     {
-        CHPageOffsetEntry()
-        {
-        }
-
         int nobjects{0};
         int nshared_objects{0};
         // vectors' sizes = nshared_objects
@@ -1293,10 +1265,6 @@ class QPDF
     // PDF 1.4: Table F.5
     struct CHSharedObject
     {
-        CHSharedObject()
-        {
-        }
-
         int first_shared_obj{0};
         int nshared_first_page{0};
         int nshared_total{0};

include/qpdf/QPDFJob.hh

@@ -145,10 +145,6 @@ class QPDFJob
 
     struct AddAttachment
     {
-        AddAttachment()
-        {
-        }
-
         std::string path;
         std::string key;
         std::string filename;

libqpdf/ClosedFileInputSource.cc

@@ -9,7 +9,7 @@ ClosedFileInputSource::ClosedFileInputSource(char const* filename) :
 {
 }
 
-ClosedFileInputSource::~ClosedFileInputSource()
+ClosedFileInputSource::~ClosedFileInputSource() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_Buffer.cc

@@ -11,7 +11,7 @@ Pl_Buffer::Pl_Buffer(char const* identifier, Pipeline* next) :
 {
 }
 
-Pl_Buffer::~Pl_Buffer()
+Pl_Buffer::~Pl_Buffer() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_Concatenate.cc

@@ -5,7 +5,7 @@ Pl_Concatenate::Pl_Concatenate(char const* identifier, Pipeline* next) :
 {
 }
 
-Pl_Concatenate::~Pl_Concatenate()
+Pl_Concatenate::~Pl_Concatenate() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_Count.cc

@@ -14,7 +14,7 @@ Pl_Count::Pl_Count(char const* identifier, Pipeline* next) :
 {
 }
 
-Pl_Count::~Pl_Count()
+Pl_Count::~Pl_Count() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_DCT.cc

@@ -75,7 +75,7 @@ Pl_DCT::Pl_DCT(
 {
 }
 
-Pl_DCT::~Pl_DCT()
+Pl_DCT::~Pl_DCT() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_Discard.cc

@@ -7,7 +7,7 @@ Pl_Discard::Pl_Discard() :
 {
 }
 
-Pl_Discard::~Pl_Discard()
+Pl_Discard::~Pl_Discard() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_Flate.cc

@@ -58,7 +58,7 @@ Pl_Flate::Pl_Flate(
 {
 }
 
-Pl_Flate::~Pl_Flate()
+Pl_Flate::~Pl_Flate() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_Function.cc

@@ -39,7 +39,7 @@ Pl_Function::Pl_Function(char const* identifier, Pipeline* next, writer_c_char_t
     };
 }
 
-Pl_Function::~Pl_Function()
+Pl_Function::~Pl_Function() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_OStream.cc

@@ -13,7 +13,7 @@ Pl_OStream::Pl_OStream(char const* identifier, std::ostream& os) :
 {
 }
 
-Pl_OStream::~Pl_OStream()
+Pl_OStream::~Pl_OStream() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_QPDFTokenizer.cc

@@ -21,7 +21,7 @@ Pl_QPDFTokenizer::Pl_QPDFTokenizer(
     m->tokenizer.includeIgnorable();
 }
 
-Pl_QPDFTokenizer::~Pl_QPDFTokenizer()
+Pl_QPDFTokenizer::~Pl_QPDFTokenizer() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_RunLength.cc

@@ -16,7 +16,7 @@ Pl_RunLength::Pl_RunLength(char const* identifier, Pipeline* next, action_e acti
 {
 }
 
-Pl_RunLength::~Pl_RunLength()
+Pl_RunLength::~Pl_RunLength() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_StdioFile.cc

@@ -17,7 +17,7 @@ Pl_StdioFile::Pl_StdioFile(char const* identifier, FILE* f) :
 {
 }
 
-Pl_StdioFile::~Pl_StdioFile()
+Pl_StdioFile::~Pl_StdioFile() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/Pl_String.cc

@@ -13,7 +13,7 @@ Pl_String::Pl_String(char const* identifier, Pipeline* next, std::string& s) :
 {
 }
 
-Pl_String::~Pl_String()
+Pl_String::~Pl_String() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/QPDFDocumentHelper.cc

@@ -1,6 +1,6 @@
 #include <qpdf/QPDFDocumentHelper.hh>
 
-QPDFDocumentHelper::~QPDFDocumentHelper()
+QPDFDocumentHelper::~QPDFDocumentHelper() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/QPDFFormFieldObjectHelper.cc

@@ -647,10 +647,8 @@ namespace
     class TfFinder: public QPDFObjectHandle::TokenFilter
     {
       public:
-        TfFinder();
+        TfFinder() = default;
-        ~TfFinder() override
+        ~TfFinder() override = default;
-        {
-        }
         void handleToken(QPDFTokenizer::Token const&) override;
         double getTf();
         std::string getFontName();
@@ -667,10 +665,6 @@ namespace
     };
 } // namespace
 
-TfFinder::TfFinder()
-{
-}
-
 void
 TfFinder::handleToken(QPDFTokenizer::Token const& token)
 {

libqpdf/QPDFNameTreeObjectHelper.cc

@@ -34,7 +34,7 @@ namespace
 
 static NameTreeDetails name_tree_details;
 
-QPDFNameTreeObjectHelper::~QPDFNameTreeObjectHelper()
+QPDFNameTreeObjectHelper::~QPDFNameTreeObjectHelper() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer. For this specific
     // class, see github issue #745.

libqpdf/QPDFNumberTreeObjectHelper.cc

@@ -35,7 +35,7 @@ namespace
 
 static NumberTreeDetails number_tree_details;
 
-QPDFNumberTreeObjectHelper::~QPDFNumberTreeObjectHelper()
+QPDFNumberTreeObjectHelper::~QPDFNumberTreeObjectHelper() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer. For this specific
     // class, see github issue #745.

libqpdf/QPDFObjectHandle.cc

@@ -49,7 +49,7 @@ QPDFObjectHandle::StreamDataProvider::StreamDataProvider(bool supports_retry) :
 {
 }
 
-QPDFObjectHandle::StreamDataProvider::~StreamDataProvider()
+QPDFObjectHandle::StreamDataProvider::~StreamDataProvider() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/QPDFObjectHelper.cc

@@ -1,6 +1,6 @@
 #include <qpdf/QPDFObjectHelper.hh>
 
-QPDFObjectHelper::~QPDFObjectHelper()
+QPDFObjectHelper::~QPDFObjectHelper() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/QPDFWriter.cc

@@ -26,7 +26,7 @@
 #include <cstdlib>
 #include <stdexcept>
 
-QPDFWriter::ProgressReporter::~ProgressReporter()
+QPDFWriter::ProgressReporter::~ProgressReporter() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }
@@ -36,7 +36,8 @@ QPDFWriter::FunctionProgressReporter::FunctionProgressReporter(std::function<voi
 {
 }
 
-QPDFWriter::FunctionProgressReporter::~FunctionProgressReporter()
+QPDFWriter::FunctionProgressReporter::~FunctionProgressReporter() // NOLINT
+                                                                  // (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer
 }

libqpdf/QPDFXRefEntry.cc

@@ -3,7 +3,7 @@
 #include <qpdf/QIntC.hh>
 #include <qpdf/QPDFExc.hh>
 
-QPDFXRefEntry::QPDFXRefEntry()
+QPDFXRefEntry::QPDFXRefEntry() // NOLINT (modernize-use-equals-default)
 {
 }
 

libqpdf/qpdf/QPDFArgParser.hh

@@ -145,9 +145,6 @@ class QPDFArgParser
   private:
     struct OptionEntry
     {
-        OptionEntry()
-        {
-        }
         bool parameter_needed{false};
         std::string parameter_name;
         std::set<std::string> choices;

libtests/dct_compress.cc

@@ -17,9 +17,7 @@ usage()
 class Callback: public Pl_DCT::CompressConfig
 {
   public:
-    Callback()
+    Callback() = default;
-    {
-    }
     ~Callback() override = default;
     void apply(jpeg_compress_struct*) override;
     bool called{false};