diff --git a/ChangeLog b/ChangeLog index 168d8d70..2c2bb836 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,9 +1,3 @@ -2023-09-03 Jay Berkenbilt - - * Bug fix: with --pages, if one of the external files had warnings - but the main file did not, the warning was previously not taken - into consideration when determining the exit status. - 2023-09-02 Jay Berkenbilt * Bug fix from M. Holger: allow fix-qdf to read from pipe. Fixes #1010. diff --git a/libqpdf/QPDFJob.cc b/libqpdf/QPDFJob.cc index adce2358..b8ae7787 100644 --- a/libqpdf/QPDFJob.cc +++ b/libqpdf/QPDFJob.cc @@ -2561,11 +2561,6 @@ QPDFJob::handlePageSpecs(QPDF& pdf, std::vector>& page_hea } } } - for (auto const& p: page_spec_qpdfs) { - if (!p.second->getWarnings().empty()) { - m->warnings = true; - } - } } void diff --git a/qpdf/qtest/page-errors.test b/qpdf/qtest/page-errors.test index 3f14f24e..60894f96 100644 --- a/qpdf/qtest/page-errors.test +++ b/qpdf/qtest/page-errors.test @@ -22,7 +22,7 @@ $td->runtest("handle page no with contents", $td->NORMALIZE_NEWLINES); $td->runtest("handle page with missing MediaBox", {$td->COMMAND => "qpdf --static-id --empty --pages page-no-content.pdf -- out.pdf"}, - {$td->FILE => "page-missing-mediabox.out", $td->EXIT_STATUS => 3}, + {$td->FILE => "page-missing-mediabox.out", $td->EXIT_STATUS => 0}, $td->NORMALIZE_NEWLINES); $td->runtest("check output", {$td->FILE => "out.pdf"}, diff --git a/qpdf/qtest/qpdf/page-missing-mediabox.out b/qpdf/qtest/qpdf/page-missing-mediabox.out index 91e85707..9db62ed6 100644 --- a/qpdf/qtest/qpdf/page-missing-mediabox.out +++ b/qpdf/qtest/qpdf/page-missing-mediabox.out @@ -1,2 +1 @@ WARNING: page-no-content.pdf, object 4 0 at offset 288: kid 1 (from 0) MediaBox is undefined; setting to letter / ANSI A -qpdf: operation succeeded with warnings; resulting file may have some problems