octoleo/qpdf
2
1
Fork 0
mirror of https://github.com/qpdf/qpdf.git synced 2024-12-22 10:58:58 +00:00
Code Issues Releases Wiki Activity

Tune QPDFWriter::writeString etc methods

Browse Source 
Use string_view parameters and call pipeline write methods directly.
This commit is contained in:
m-holger 2023-01-22 18:25:17 +00:00 committed by Jay Berkenbilt
parent e8cdc46286
commit d16308b3f5
2 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
include/qpdf/QPDFWriter.hh
View File

@ -36,6 +36,7 @@
#include <set>
#include <stdio.h>
#include <string>
#include <string_view>
#include <vector>
#include <qpdf/Constants.h>
@ -553,10 +554,10 @@ class QPDFWriter
unsigned int bytesNeeded(long long n);
void writeBinary(unsigned long long val, unsigned int bytes);
void writeString(std::string const& str);
void writeString(std::string_view str);
void writeBuffer(std::shared_ptr<Buffer>&);
void writeStringQDF(std::string const& str);
void writeStringNoQDF(std::string const& str);
void writeStringQDF(std::string_view str);
void writeStringNoQDF(std::string_view str);
void writePad(size_t nspaces);
void assignCompressedObjectNumbers(QPDFObjGen const& og);
void enqueueObject(QPDFObjectHandle object);

19
libqpdf/QPDFWriter.cc
View File

@ -982,9 +982,10 @@ QPDFWriter::writeBinary(unsigned long long val, unsigned int bytes)
}
void
QPDFWriter::writeString(std::string const& str)
QPDFWriter::writeString(std::string_view str)
{
this->m->pipeline->writeString(str);
m->pipeline->write(
reinterpret_cast<unsigned char const*>(str.data()), str.size());
}
void
@ -994,18 +995,20 @@ QPDFWriter::writeBuffer(std::shared_ptr<Buffer>& b)
}
void
QPDFWriter::writeStringQDF(std::string const& str)
QPDFWriter::writeStringQDF(std::string_view str)
{
if (this->m->qdf_mode) {
writeString(str);
if (m->qdf_mode) {
m->pipeline->write(
reinterpret_cast<unsigned char const*>(str.data()), str.size());
}
}
void
QPDFWriter::writeStringNoQDF(std::string const& str)
QPDFWriter::writeStringNoQDF(std::string_view str)
{
if (!this->m->qdf_mode) {
writeString(str);
if (!m->qdf_mode) {
m->pipeline->write(
reinterpret_cast<unsigned char const*>(str.data()), str.size());
}
}