mirror of
https://github.com/qpdf/qpdf.git
synced 2024-11-18 10:25:12 +00:00
d71f05ca07
This makes all integer type conversions that have potential data loss explicit with calls that do range checks and raise an exception. After this commit, qpdf builds with no warnings when -Wsign-conversion -Wconversion is used with gcc or clang or when -W3 -Wd4800 is used with MSVC. This significantly reduces the likelihood of potential crashes from bogus integer values. There are some parts of the code that take int when they should take size_t or an offset. Such places would make qpdf not support files with more than 2^31 of something that usually wouldn't be so large. In the event that such a file shows up and is valid, at least qpdf would raise an error in the right spot so the issue could be legitimately addressed rather than failing in some weird way because of a silent overflow condition.
151 lines
3.6 KiB
C++
151 lines
3.6 KiB
C++
#include <qpdf/Pl_AES_PDF.hh>
|
|
#include <qpdf/Pl_StdioFile.hh>
|
|
#include <qpdf/QUtil.hh>
|
|
#include <qpdf/QIntC.hh>
|
|
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <iostream>
|
|
#include <stdlib.h>
|
|
|
|
static void usage()
|
|
{
|
|
std::cerr << "Usage: aes options hex-key infile outfile" << std::endl
|
|
<< " -cbc -- disable CBC mode" << std::endl
|
|
<< " +cbc -- enable CBC mode" << std::endl
|
|
<< " -encrypt -- encrypt" << std::endl
|
|
<< " -decrypt -- decrypt CBC mode" << std::endl
|
|
<< " -zero-iv -- use zero initialization vector" << std::endl
|
|
<< " -static-iv -- use static initialization vector" << std::endl
|
|
<< " -no-padding -- disable padding" << std::endl
|
|
<< "Options must precede key and file names." << std::endl;
|
|
exit(2);
|
|
}
|
|
|
|
int main(int argc, char* argv[])
|
|
{
|
|
bool encrypt = true;
|
|
bool cbc_mode = true;
|
|
char* hexkey = 0;
|
|
char* infilename = 0;
|
|
char* outfilename = 0;
|
|
bool zero_iv = false;
|
|
bool static_iv = false;
|
|
bool disable_padding = false;
|
|
|
|
for (int i = 1; i < argc; ++i)
|
|
{
|
|
char* arg = argv[i];
|
|
if ((arg[0] == '-') || (arg[0] == '+'))
|
|
{
|
|
if (strcmp(arg, "-cbc") == 0)
|
|
{
|
|
cbc_mode = false;
|
|
}
|
|
else if (strcmp(arg, "+cbc") == 0)
|
|
{
|
|
cbc_mode = true;
|
|
}
|
|
else if (strcmp(arg, "-decrypt") == 0)
|
|
{
|
|
encrypt = false;
|
|
}
|
|
else if (strcmp(arg, "-encrypt") == 0)
|
|
{
|
|
encrypt = true;
|
|
}
|
|
else if (strcmp(arg, "-zero-iv") == 0)
|
|
{
|
|
zero_iv = true;
|
|
}
|
|
else if (strcmp(arg, "-static-iv") == 0)
|
|
{
|
|
static_iv = true;
|
|
}
|
|
else if (strcmp(arg, "-no-padding") == 0)
|
|
{
|
|
disable_padding = true;
|
|
}
|
|
else
|
|
{
|
|
usage();
|
|
}
|
|
}
|
|
else if (argc == i + 3)
|
|
{
|
|
hexkey = argv[i];
|
|
infilename = argv[i+1];
|
|
outfilename = argv[i+2];
|
|
break;
|
|
}
|
|
else
|
|
{
|
|
usage();
|
|
}
|
|
}
|
|
if (outfilename == 0)
|
|
{
|
|
usage();
|
|
}
|
|
|
|
unsigned int hexkeylen = QIntC::to_uint(strlen(hexkey));
|
|
unsigned int keylen = hexkeylen / 2;
|
|
|
|
FILE* infile = QUtil::safe_fopen(infilename, "rb");
|
|
FILE* outfile = QUtil::safe_fopen(outfilename, "wb");
|
|
unsigned char* key = new unsigned char[keylen];
|
|
for (unsigned int i = 0; i < strlen(hexkey); i += 2)
|
|
{
|
|
char t[3];
|
|
t[0] = hexkey[i];
|
|
t[1] = hexkey[i + 1];
|
|
t[2] = '\0';
|
|
|
|
long val = strtol(t, 0, 16);
|
|
key[i/2] = static_cast<unsigned char>(val);
|
|
}
|
|
|
|
Pl_StdioFile* out = new Pl_StdioFile("stdout", outfile);
|
|
Pl_AES_PDF* aes = new Pl_AES_PDF("aes_128_cbc", out, encrypt, key, keylen);
|
|
delete [] key;
|
|
key = 0;
|
|
if (! cbc_mode)
|
|
{
|
|
aes->disableCBC();
|
|
}
|
|
if (zero_iv)
|
|
{
|
|
aes->useZeroIV();
|
|
}
|
|
else if (static_iv)
|
|
{
|
|
aes->useStaticIV();
|
|
}
|
|
if (disable_padding)
|
|
{
|
|
aes->disablePadding();
|
|
}
|
|
|
|
// 16 < buffer size, buffer_size is not a multiple of 8 for testing
|
|
unsigned char buf[83];
|
|
bool done = false;
|
|
while (! done)
|
|
{
|
|
size_t len = fread(buf, 1, sizeof(buf), infile);
|
|
if (len <= 0)
|
|
{
|
|
done = true;
|
|
}
|
|
else
|
|
{
|
|
aes->write(buf, len);
|
|
}
|
|
}
|
|
aes->finish();
|
|
delete aes;
|
|
delete out;
|
|
fclose(infile);
|
|
fclose(outfile);
|
|
return 0;
|
|
}
|