mirror of
https://github.com/qpdf/qpdf.git
synced 2025-01-09 01:44:16 +00:00
d71f05ca07
This makes all integer type conversions that have potential data loss explicit with calls that do range checks and raise an exception. After this commit, qpdf builds with no warnings when -Wsign-conversion -Wconversion is used with gcc or clang or when -W3 -Wd4800 is used with MSVC. This significantly reduces the likelihood of potential crashes from bogus integer values. There are some parts of the code that take int when they should take size_t or an offset. Such places would make qpdf not support files with more than 2^31 of something that usually wouldn't be so large. In the event that such a file shows up and is valid, at least qpdf would raise an error in the right spot so the issue could be legitimately addressed rather than failing in some weird way because of a silent overflow condition.
14 lines
1.1 KiB
Plaintext
14 lines
1.1 KiB
Plaintext
QIntC::to_int<int32_t>(i1): -1153374643 -1153374643 PASSED
|
|
QIntC::to_uint<uint32_t>(u1): 3141592653 3141592653 PASSED
|
|
QIntC::to_int<uint32_t>(u1): integer out of range converting 3141592653 from a 4-byte unsigned type to a 4-byte signed type PASSED
|
|
QIntC::to_uint<int32_t>(i1): integer out of range converting -1153374643 from a 4-byte signed type to a 4-byte unsigned type PASSED
|
|
QIntC::to_int<uint64_t>(ul1): integer out of range converting 1099511627776 from a 8-byte unsigned type to a 4-byte signed type PASSED
|
|
QIntC::to_int<uint64_t>(ul2): 12345 12345 PASSED
|
|
QIntC::to_uint<uint64_t>(ul2): 12345 12345 PASSED
|
|
QIntC::to_offset<uint32_t>(u1): 3141592653 3141592653 PASSED
|
|
QIntC::to_offset<int32_t>(i1): -1153374643 -1153374643 PASSED
|
|
QIntC::to_ulonglong<int32_t>(i1): integer out of range converting -1153374643 from a 4-byte signed type to a 8-byte unsigned type PASSED
|
|
QIntC::to_char<int32_t>(i2): 81 Q PASSED
|
|
QIntC::to_uchar<int32_t>(i2): 81 Q PASSED
|
|
QIntC::to_uchar<char>(c1): integer out of range converting ÷ from a 1-byte signed type to a 1-byte unsigned type PASSED
|