mirror of
https://github.com/qpdf/qpdf.git
synced 2024-11-04 20:37:50 +00:00
d71f05ca07
This makes all integer type conversions that have potential data loss explicit with calls that do range checks and raise an exception. After this commit, qpdf builds with no warnings when -Wsign-conversion -Wconversion is used with gcc or clang or when -W3 -Wd4800 is used with MSVC. This significantly reduces the likelihood of potential crashes from bogus integer values. There are some parts of the code that take int when they should take size_t or an offset. Such places would make qpdf not support files with more than 2^31 of something that usually wouldn't be so large. In the event that such a file shows up and is valid, at least qpdf would raise an error in the right spot so the issue could be legitimately addressed rather than failing in some weird way because of a silent overflow condition.
163 lines
3.5 KiB
C++
163 lines
3.5 KiB
C++
#include <qpdf/BufferInputSource.hh>
|
|
#include <qpdf/QIntC.hh>
|
|
#include <string.h>
|
|
#include <stdexcept>
|
|
#include <algorithm>
|
|
|
|
BufferInputSource::BufferInputSource(std::string const& description,
|
|
Buffer* buf, bool own_memory) :
|
|
own_memory(own_memory),
|
|
description(description),
|
|
buf(buf),
|
|
cur_offset(0)
|
|
{
|
|
}
|
|
|
|
BufferInputSource::BufferInputSource(std::string const& description,
|
|
std::string const& contents) :
|
|
own_memory(true),
|
|
description(description),
|
|
buf(0),
|
|
cur_offset(0)
|
|
{
|
|
this->buf = new Buffer(contents.length());
|
|
unsigned char* bp = buf->getBuffer();
|
|
memcpy(bp, contents.c_str(), contents.length());
|
|
}
|
|
|
|
BufferInputSource::~BufferInputSource()
|
|
{
|
|
if (own_memory)
|
|
{
|
|
delete this->buf;
|
|
}
|
|
}
|
|
|
|
qpdf_offset_t const
|
|
BufferInputSource::bufSizeAsOffset() const
|
|
{
|
|
return QIntC::to_offset(this->buf->getSize());
|
|
}
|
|
|
|
qpdf_offset_t
|
|
BufferInputSource::findAndSkipNextEOL()
|
|
{
|
|
if (this->cur_offset < 0)
|
|
{
|
|
throw std::logic_error("INTERNAL ERROR: BufferInputSource offset < 0");
|
|
}
|
|
qpdf_offset_t end_pos = bufSizeAsOffset();
|
|
if (this->cur_offset >= end_pos)
|
|
{
|
|
this->last_offset = end_pos;
|
|
this->cur_offset = end_pos;
|
|
return end_pos;
|
|
}
|
|
|
|
qpdf_offset_t result = 0;
|
|
size_t len = QIntC::to_size(end_pos - this->cur_offset);
|
|
unsigned char const* buffer = this->buf->getBuffer();
|
|
|
|
void* start = const_cast<unsigned char*>(buffer) + this->cur_offset;
|
|
unsigned char* p1 = static_cast<unsigned char*>(memchr(start, '\r', len));
|
|
unsigned char* p2 = static_cast<unsigned char*>(memchr(start, '\n', len));
|
|
unsigned char* p = (p1 && p2) ? std::min(p1, p2) : p1 ? p1 : p2;
|
|
if (p)
|
|
{
|
|
result = p - buffer;
|
|
this->cur_offset = result + 1;
|
|
++p;
|
|
while ((this->cur_offset < end_pos) &&
|
|
((*p == '\r') || (*p == '\n')))
|
|
{
|
|
++p;
|
|
++this->cur_offset;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
this->cur_offset = end_pos;
|
|
result = end_pos;
|
|
}
|
|
return result;
|
|
}
|
|
|
|
std::string const&
|
|
BufferInputSource::getName() const
|
|
{
|
|
return this->description;
|
|
}
|
|
|
|
qpdf_offset_t
|
|
BufferInputSource::tell()
|
|
{
|
|
return this->cur_offset;
|
|
}
|
|
|
|
void
|
|
BufferInputSource::seek(qpdf_offset_t offset, int whence)
|
|
{
|
|
switch (whence)
|
|
{
|
|
case SEEK_SET:
|
|
this->cur_offset = offset;
|
|
break;
|
|
|
|
case SEEK_END:
|
|
this->cur_offset = bufSizeAsOffset() + offset;
|
|
break;
|
|
|
|
case SEEK_CUR:
|
|
this->cur_offset += offset;
|
|
break;
|
|
|
|
default:
|
|
throw std::logic_error(
|
|
"INTERNAL ERROR: invalid argument to BufferInputSource::seek");
|
|
break;
|
|
}
|
|
|
|
if (this->cur_offset < 0)
|
|
{
|
|
throw std::runtime_error(
|
|
this->description + ": seek before beginning of buffer");
|
|
}
|
|
}
|
|
|
|
void
|
|
BufferInputSource::rewind()
|
|
{
|
|
this->cur_offset = 0;
|
|
}
|
|
|
|
size_t
|
|
BufferInputSource::read(char* buffer, size_t length)
|
|
{
|
|
if (this->cur_offset < 0)
|
|
{
|
|
throw std::logic_error("INTERNAL ERROR: BufferInputSource offset < 0");
|
|
}
|
|
qpdf_offset_t end_pos = bufSizeAsOffset();
|
|
if (this->cur_offset >= end_pos)
|
|
{
|
|
this->last_offset = end_pos;
|
|
return 0;
|
|
}
|
|
|
|
this->last_offset = this->cur_offset;
|
|
size_t len = std::min(
|
|
QIntC::to_size(end_pos - this->cur_offset), length);
|
|
memcpy(buffer, buf->getBuffer() + this->cur_offset, len);
|
|
this->cur_offset += QIntC::to_offset(len);
|
|
return len;
|
|
}
|
|
|
|
void
|
|
BufferInputSource::unreadCh(char ch)
|
|
{
|
|
if (this->cur_offset > 0)
|
|
{
|
|
--this->cur_offset;
|
|
}
|
|
}
|