2021-01-22 00:17:43 +00:00
|
|
|
<?php
|
|
|
|
|
2021-05-09 20:15:43 +00:00
|
|
|
declare (strict_types=1);
|
2021-01-22 00:17:43 +00:00
|
|
|
namespace Rector\Php80\Rector\ClassMethod;
|
|
|
|
|
|
|
|
use PhpParser\Node;
|
2021-01-22 09:16:00 +00:00
|
|
|
use PhpParser\Node\Expr\MethodCall;
|
2021-01-22 01:41:09 +00:00
|
|
|
use PhpParser\Node\Expr\New_;
|
2021-01-22 00:17:43 +00:00
|
|
|
use PhpParser\Node\Stmt\ClassMethod;
|
2021-04-11 10:27:20 +00:00
|
|
|
use PHPStan\Type\TypeWithClassName;
|
2021-01-22 00:17:43 +00:00
|
|
|
use Rector\Core\Rector\AbstractRector;
|
2021-04-11 10:27:20 +00:00
|
|
|
use Rector\Core\ValueObject\MethodName;
|
2021-01-22 01:41:09 +00:00
|
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
2021-01-22 09:16:00 +00:00
|
|
|
use Rector\Php80\NodeResolver\ArgumentSorter;
|
2021-01-22 01:41:09 +00:00
|
|
|
use Rector\Php80\NodeResolver\RequireOptionalParamResolver;
|
2021-04-11 10:27:20 +00:00
|
|
|
use Rector\Php80\Reflection\MethodReflectionClassMethodResolver;
|
2021-01-22 00:17:43 +00:00
|
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
|
|
/**
|
2021-04-10 18:47:17 +00:00
|
|
|
* @changelog https://php.watch/versions/8.0#deprecate-required-param-after-optional
|
2021-01-22 00:17:43 +00:00
|
|
|
*
|
2021-03-12 22:20:25 +00:00
|
|
|
* @see \Rector\Tests\Php80\Rector\ClassMethod\OptionalParametersAfterRequiredRector\OptionalParametersAfterRequiredRectorTest
|
2021-01-22 00:17:43 +00:00
|
|
|
*/
|
2021-05-10 22:23:08 +00:00
|
|
|
final class OptionalParametersAfterRequiredRector extends \Rector\Core\Rector\AbstractRector
|
2021-01-22 00:17:43 +00:00
|
|
|
{
|
2021-01-22 01:41:09 +00:00
|
|
|
/**
|
2021-05-10 23:39:21 +00:00
|
|
|
* @var \Rector\Php80\NodeResolver\RequireOptionalParamResolver
|
2021-01-22 01:41:09 +00:00
|
|
|
*/
|
|
|
|
private $requireOptionalParamResolver;
|
2021-01-22 09:16:00 +00:00
|
|
|
/**
|
2021-05-10 23:39:21 +00:00
|
|
|
* @var \Rector\Php80\NodeResolver\ArgumentSorter
|
2021-01-22 09:16:00 +00:00
|
|
|
*/
|
|
|
|
private $argumentSorter;
|
2021-04-11 10:27:20 +00:00
|
|
|
/**
|
2021-05-10 23:39:21 +00:00
|
|
|
* @var \Rector\Php80\Reflection\MethodReflectionClassMethodResolver
|
2021-04-11 10:27:20 +00:00
|
|
|
*/
|
|
|
|
private $methodReflectionClassMethodResolver;
|
2021-05-10 22:23:08 +00:00
|
|
|
public function __construct(\Rector\Php80\NodeResolver\RequireOptionalParamResolver $requireOptionalParamResolver, \Rector\Php80\NodeResolver\ArgumentSorter $argumentSorter, \Rector\Php80\Reflection\MethodReflectionClassMethodResolver $methodReflectionClassMethodResolver)
|
2021-05-09 20:15:43 +00:00
|
|
|
{
|
2021-01-22 01:41:09 +00:00
|
|
|
$this->requireOptionalParamResolver = $requireOptionalParamResolver;
|
2021-01-22 09:16:00 +00:00
|
|
|
$this->argumentSorter = $argumentSorter;
|
2021-04-11 10:27:20 +00:00
|
|
|
$this->methodReflectionClassMethodResolver = $methodReflectionClassMethodResolver;
|
2021-01-22 01:41:09 +00:00
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
2021-01-22 00:17:43 +00:00
|
|
|
{
|
2021-05-10 22:23:08 +00:00
|
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Move required parameters after optional ones', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
2021-01-22 00:17:43 +00:00
|
|
|
class SomeObject
|
|
|
|
{
|
|
|
|
public function run($optional = 1, $required)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
}
|
|
|
|
CODE_SAMPLE
|
2021-05-09 20:15:43 +00:00
|
|
|
, <<<'CODE_SAMPLE'
|
2021-01-22 00:17:43 +00:00
|
|
|
class SomeObject
|
|
|
|
{
|
|
|
|
public function run($required, $optional = 1)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
}
|
|
|
|
CODE_SAMPLE
|
2021-05-09 20:15:43 +00:00
|
|
|
)]);
|
2021-01-22 00:17:43 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-02-27 00:06:15 +00:00
|
|
|
* @return array<class-string<Node>>
|
2021-01-22 00:17:43 +00:00
|
|
|
*/
|
2021-05-09 20:15:43 +00:00
|
|
|
public function getNodeTypes() : array
|
2021-01-22 00:17:43 +00:00
|
|
|
{
|
2021-05-10 22:23:08 +00:00
|
|
|
return [\PhpParser\Node\Stmt\ClassMethod::class, \PhpParser\Node\Expr\New_::class, \PhpParser\Node\Expr\MethodCall::class];
|
2021-01-22 00:17:43 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-01-22 09:16:00 +00:00
|
|
|
* @param ClassMethod|New_|MethodCall $node
|
2021-01-22 00:17:43 +00:00
|
|
|
*/
|
2021-05-10 22:23:08 +00:00
|
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
2021-01-22 00:17:43 +00:00
|
|
|
{
|
2021-05-10 22:23:08 +00:00
|
|
|
if ($node instanceof \PhpParser\Node\Stmt\ClassMethod) {
|
2021-01-22 01:41:09 +00:00
|
|
|
return $this->refactorClassMethod($node);
|
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
if ($node instanceof \PhpParser\Node\Expr\New_) {
|
2021-01-22 09:16:00 +00:00
|
|
|
return $this->refactorNew($node);
|
|
|
|
}
|
|
|
|
return $this->refactorMethodCall($node);
|
2021-01-22 01:41:09 +00:00
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
private function refactorClassMethod(\PhpParser\Node\Stmt\ClassMethod $classMethod) : ?\PhpParser\Node\Stmt\ClassMethod
|
2021-01-22 01:41:09 +00:00
|
|
|
{
|
|
|
|
if ($classMethod->params === []) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
$expectedOrderParams = $this->requireOptionalParamResolver->resolve($classMethod);
|
|
|
|
if ($classMethod->params === $expectedOrderParams) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
$classMethod->params = $expectedOrderParams;
|
|
|
|
return $classMethod;
|
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
private function refactorNew(\PhpParser\Node\Expr\New_ $new) : ?\PhpParser\Node\Expr\New_
|
2021-01-22 01:41:09 +00:00
|
|
|
{
|
|
|
|
if ($new->args === []) {
|
2021-01-22 00:17:43 +00:00
|
|
|
return null;
|
|
|
|
}
|
2021-04-11 10:27:20 +00:00
|
|
|
$newClassType = $this->nodeTypeResolver->resolve($new->class);
|
2021-05-10 22:23:08 +00:00
|
|
|
if (!$newClassType instanceof \PHPStan\Type\TypeWithClassName) {
|
2021-01-22 01:41:09 +00:00
|
|
|
return null;
|
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
$classMethod = $this->methodReflectionClassMethodResolver->resolve($newClassType->getClassName(), \Rector\Core\ValueObject\MethodName::CONSTRUCT);
|
|
|
|
if (!$classMethod instanceof \PhpParser\Node\Stmt\ClassMethod) {
|
2021-01-22 01:41:09 +00:00
|
|
|
return null;
|
|
|
|
}
|
2021-04-11 10:27:20 +00:00
|
|
|
$expectedOrderedParams = $this->requireOptionalParamResolver->resolve($classMethod);
|
|
|
|
if ($expectedOrderedParams === $classMethod->getParams()) {
|
2021-01-22 00:17:43 +00:00
|
|
|
return null;
|
|
|
|
}
|
2021-05-09 20:15:43 +00:00
|
|
|
if (\count($new->args) !== \count($classMethod->getParams())) {
|
2021-01-22 09:37:29 +00:00
|
|
|
return null;
|
|
|
|
}
|
2021-01-22 09:16:00 +00:00
|
|
|
$newArgs = $this->argumentSorter->sortArgsByExpectedParamOrder($new->args, $expectedOrderedParams);
|
2021-01-22 01:41:09 +00:00
|
|
|
if ($new->args === $newArgs) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
$new->args = $newArgs;
|
|
|
|
return $new;
|
2021-01-22 00:17:43 +00:00
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
private function refactorMethodCall(\PhpParser\Node\Expr\MethodCall $methodCall) : ?\PhpParser\Node\Expr\MethodCall
|
2021-01-22 00:17:43 +00:00
|
|
|
{
|
2021-01-22 09:16:00 +00:00
|
|
|
$classMethod = $this->nodeRepository->findClassMethodByMethodCall($methodCall);
|
2021-05-10 22:23:08 +00:00
|
|
|
if (!$classMethod instanceof \PhpParser\Node\Stmt\ClassMethod) {
|
2021-01-22 01:41:09 +00:00
|
|
|
return null;
|
|
|
|
}
|
2021-01-22 09:16:00 +00:00
|
|
|
// because parameters can be already changed
|
2021-05-10 22:23:08 +00:00
|
|
|
$originalClassMethod = $classMethod->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::ORIGINAL_NODE);
|
|
|
|
if (!$originalClassMethod instanceof \PhpParser\Node\Stmt\ClassMethod) {
|
2021-01-22 01:41:09 +00:00
|
|
|
return null;
|
|
|
|
}
|
2021-01-22 09:16:00 +00:00
|
|
|
$expectedOrderedParams = $this->requireOptionalParamResolver->resolve($originalClassMethod);
|
|
|
|
if ($expectedOrderedParams === $classMethod->getParams()) {
|
2021-01-22 01:41:09 +00:00
|
|
|
return null;
|
2021-01-22 00:17:43 +00:00
|
|
|
}
|
2021-05-09 20:15:43 +00:00
|
|
|
if (\count($methodCall->args) !== \count($classMethod->getParams())) {
|
2021-01-22 09:37:29 +00:00
|
|
|
return null;
|
|
|
|
}
|
2021-01-22 09:16:00 +00:00
|
|
|
$newArgs = $this->argumentSorter->sortArgsByExpectedParamOrder($methodCall->args, $expectedOrderedParams);
|
|
|
|
if ($methodCall->args === $newArgs) {
|
|
|
|
return null;
|
2021-01-22 00:17:43 +00:00
|
|
|
}
|
2021-01-22 09:16:00 +00:00
|
|
|
$methodCall->args = $newArgs;
|
|
|
|
return $methodCall;
|
2021-01-22 00:17:43 +00:00
|
|
|
}
|
|
|
|
}
|