2021-10-05 08:51:30 +00:00
|
|
|
<?php
|
|
|
|
|
|
|
|
declare (strict_types=1);
|
2022-06-06 17:12:56 +00:00
|
|
|
namespace Rector\Strict\Rector\Ternary;
|
2021-10-05 08:51:30 +00:00
|
|
|
|
2022-06-06 17:12:56 +00:00
|
|
|
use PhpParser\Node;
|
|
|
|
use PhpParser\Node\Expr;
|
|
|
|
use PhpParser\Node\Expr\Ternary;
|
|
|
|
use PHPStan\Analyser\Scope;
|
|
|
|
use Rector\Strict\NodeFactory\ExactCompareFactory;
|
|
|
|
use Rector\Strict\Rector\AbstractFalsyScalarRuleFixerRector;
|
2022-06-07 09:18:30 +00:00
|
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
|
|
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
2021-10-05 08:51:30 +00:00
|
|
|
/**
|
|
|
|
* Fixer Rector for PHPStan rule:
|
|
|
|
* https://github.com/phpstan/phpstan-strict-rules/blob/master/src/Rules/BooleansInConditions/BooleanInTernaryOperatorRule.php
|
|
|
|
*
|
|
|
|
* @see \Rector\Tests\Strict\Rector\Ternary\BooleanInTernaryOperatorRuleFixerRector\BooleanInTernaryOperatorRuleFixerRectorTest
|
|
|
|
*/
|
2022-06-07 08:22:29 +00:00
|
|
|
final class BooleanInTernaryOperatorRuleFixerRector extends AbstractFalsyScalarRuleFixerRector
|
2021-10-05 08:51:30 +00:00
|
|
|
{
|
|
|
|
/**
|
2021-12-04 12:47:17 +00:00
|
|
|
* @readonly
|
2021-10-05 08:51:30 +00:00
|
|
|
* @var \Rector\Strict\NodeFactory\ExactCompareFactory
|
|
|
|
*/
|
|
|
|
private $exactCompareFactory;
|
2022-06-07 08:22:29 +00:00
|
|
|
public function __construct(ExactCompareFactory $exactCompareFactory)
|
2021-10-05 08:51:30 +00:00
|
|
|
{
|
|
|
|
$this->exactCompareFactory = $exactCompareFactory;
|
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
public function getRuleDefinition() : RuleDefinition
|
2021-10-05 08:51:30 +00:00
|
|
|
{
|
|
|
|
$errorMessage = \sprintf('Fixer for PHPStan reports by strict type rule - "%s"', 'PHPStan\\Rules\\BooleansInConditions\\BooleanInTernaryOperatorRule');
|
2022-06-07 08:22:29 +00:00
|
|
|
return new RuleDefinition($errorMessage, [new ConfiguredCodeSample(<<<'CODE_SAMPLE'
|
2021-10-05 08:51:30 +00:00
|
|
|
final class ArrayCompare
|
|
|
|
{
|
|
|
|
public function run(array $data)
|
|
|
|
{
|
|
|
|
return $data ? 1 : 2;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
CODE_SAMPLE
|
|
|
|
, <<<'CODE_SAMPLE'
|
|
|
|
final class ArrayCompare
|
|
|
|
{
|
|
|
|
public function run(array $data)
|
|
|
|
{
|
|
|
|
return $data !== [] ? 1 : 2;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
CODE_SAMPLE
|
2021-10-05 15:59:39 +00:00
|
|
|
, [self::TREAT_AS_NON_EMPTY => \false])]);
|
2021-10-05 08:51:30 +00:00
|
|
|
}
|
|
|
|
/**
|
|
|
|
* @return array<class-string<Node>>
|
|
|
|
*/
|
|
|
|
public function getNodeTypes() : array
|
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
return [Ternary::class];
|
2021-10-05 08:51:30 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-12-10 10:22:23 +00:00
|
|
|
* @param Ternary $node
|
2021-10-05 08:51:30 +00:00
|
|
|
*/
|
2023-05-11 08:30:47 +00:00
|
|
|
public function refactorWithScope(Node $node, Scope $scope) : ?Ternary
|
2021-10-05 08:51:30 +00:00
|
|
|
{
|
|
|
|
// skip short ternary
|
2023-03-23 23:21:34 +00:00
|
|
|
if (!$node->if instanceof Expr) {
|
2021-10-05 08:51:30 +00:00
|
|
|
return null;
|
|
|
|
}
|
|
|
|
$exprType = $scope->getType($node->cond);
|
2022-07-18 15:25:27 +00:00
|
|
|
$expr = $this->exactCompareFactory->createNotIdenticalFalsyCompare($exprType, $node->cond, $this->treatAsNonEmpty);
|
|
|
|
if (!$expr instanceof Expr) {
|
2021-10-05 08:51:30 +00:00
|
|
|
return null;
|
|
|
|
}
|
2022-07-18 15:25:27 +00:00
|
|
|
$node->cond = $expr;
|
2021-10-05 08:51:30 +00:00
|
|
|
return $node;
|
|
|
|
}
|
|
|
|
}
|