2019-10-13 05:59:52 +00:00
|
|
|
<?php
|
|
|
|
|
2021-05-09 20:15:43 +00:00
|
|
|
declare (strict_types=1);
|
2018-10-17 12:27:22 +00:00
|
|
|
namespace Rector\CodeQuality\Rector\Identical;
|
2018-10-12 23:02:47 +00:00
|
|
|
|
|
|
|
use PhpParser\Node;
|
|
|
|
use PhpParser\Node\Expr\BinaryOp;
|
2018-11-07 01:37:39 +00:00
|
|
|
use PhpParser\Node\Expr\BinaryOp\BooleanOr;
|
2018-10-13 09:35:23 +00:00
|
|
|
use PhpParser\Node\Expr\BinaryOp\Identical;
|
|
|
|
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
|
2018-10-12 23:02:47 +00:00
|
|
|
use PhpParser\Node\Expr\BooleanNot;
|
2021-02-08 12:33:17 +00:00
|
|
|
use Rector\Core\NodeManipulator\BinaryOpManipulator;
|
2020-02-06 21:48:18 +00:00
|
|
|
use Rector\Core\PhpParser\Node\AssignAndBinaryMap;
|
|
|
|
use Rector\Core\Rector\AbstractRector;
|
2021-01-20 11:41:35 +00:00
|
|
|
use Rector\Php71\ValueObject\TwoNodeMatch;
|
2020-11-16 17:50:38 +00:00
|
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
2019-09-03 09:11:45 +00:00
|
|
|
/**
|
2021-03-12 22:20:25 +00:00
|
|
|
* @see \Rector\Tests\CodeQuality\Rector\Identical\SimplifyConditionsRector\SimplifyConditionsRectorTest
|
2019-09-03 09:11:45 +00:00
|
|
|
*/
|
2021-05-10 22:23:08 +00:00
|
|
|
final class SimplifyConditionsRector extends \Rector\Core\Rector\AbstractRector
|
2018-10-12 23:02:47 +00:00
|
|
|
{
|
|
|
|
/**
|
2021-12-04 12:47:17 +00:00
|
|
|
* @readonly
|
2021-05-10 23:39:21 +00:00
|
|
|
* @var \Rector\Core\PhpParser\Node\AssignAndBinaryMap
|
2018-10-12 23:02:47 +00:00
|
|
|
*/
|
2018-10-27 14:02:49 +00:00
|
|
|
private $assignAndBinaryMap;
|
2018-11-07 17:04:38 +00:00
|
|
|
/**
|
2021-12-04 12:47:17 +00:00
|
|
|
* @readonly
|
2021-05-10 23:39:21 +00:00
|
|
|
* @var \Rector\Core\NodeManipulator\BinaryOpManipulator
|
2018-11-07 17:04:38 +00:00
|
|
|
*/
|
2019-02-27 21:54:39 +00:00
|
|
|
private $binaryOpManipulator;
|
2021-05-10 22:23:08 +00:00
|
|
|
public function __construct(\Rector\Core\PhpParser\Node\AssignAndBinaryMap $assignAndBinaryMap, \Rector\Core\NodeManipulator\BinaryOpManipulator $binaryOpManipulator)
|
2018-10-27 14:02:49 +00:00
|
|
|
{
|
|
|
|
$this->assignAndBinaryMap = $assignAndBinaryMap;
|
2019-02-27 21:54:39 +00:00
|
|
|
$this->binaryOpManipulator = $binaryOpManipulator;
|
2018-10-27 14:02:49 +00:00
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
2018-10-12 23:02:47 +00:00
|
|
|
{
|
2021-05-10 22:23:08 +00:00
|
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Simplify conditions', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample("if (! (\$foo !== 'bar')) {...", "if (\$foo === 'bar') {...")]);
|
2018-10-12 23:02:47 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-02-27 00:06:15 +00:00
|
|
|
* @return array<class-string<Node>>
|
2018-10-12 23:02:47 +00:00
|
|
|
*/
|
2021-05-09 20:15:43 +00:00
|
|
|
public function getNodeTypes() : array
|
2018-10-12 23:02:47 +00:00
|
|
|
{
|
2021-05-10 22:23:08 +00:00
|
|
|
return [\PhpParser\Node\Expr\BooleanNot::class, \PhpParser\Node\Expr\BinaryOp\Identical::class];
|
2018-10-12 23:02:47 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-12-10 09:57:54 +00:00
|
|
|
* @param \PhpParser\Node $node
|
2018-10-12 23:02:47 +00:00
|
|
|
*/
|
2021-12-10 09:57:54 +00:00
|
|
|
public function refactor($node) : ?\PhpParser\Node
|
2018-10-12 23:02:47 +00:00
|
|
|
{
|
2021-05-10 22:23:08 +00:00
|
|
|
if ($node instanceof \PhpParser\Node\Expr\BooleanNot) {
|
2018-10-15 12:35:45 +00:00
|
|
|
return $this->processBooleanNot($node);
|
2018-10-12 23:02:47 +00:00
|
|
|
}
|
2018-11-07 17:22:27 +00:00
|
|
|
return $this->processIdenticalAndNotIdentical($node);
|
2018-10-15 12:35:45 +00:00
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
private function processBooleanNot(\PhpParser\Node\Expr\BooleanNot $booleanNot) : ?\PhpParser\Node
|
2018-10-15 12:35:45 +00:00
|
|
|
{
|
2021-05-10 22:23:08 +00:00
|
|
|
if (!$booleanNot->expr instanceof \PhpParser\Node\Expr\BinaryOp) {
|
2018-10-21 10:19:14 +00:00
|
|
|
return null;
|
2018-10-12 23:32:15 +00:00
|
|
|
}
|
2019-02-22 17:25:31 +00:00
|
|
|
if ($this->shouldSkip($booleanNot->expr)) {
|
2018-10-21 10:19:14 +00:00
|
|
|
return null;
|
2018-10-15 12:35:45 +00:00
|
|
|
}
|
2019-02-22 17:25:31 +00:00
|
|
|
return $this->createInversedBooleanOp($booleanNot->expr);
|
2018-10-15 12:35:45 +00:00
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
private function processIdenticalAndNotIdentical(\PhpParser\Node\Expr\BinaryOp\Identical $identical) : ?\PhpParser\Node
|
2018-10-15 12:35:45 +00:00
|
|
|
{
|
2021-05-10 22:23:08 +00:00
|
|
|
$twoNodeMatch = $this->binaryOpManipulator->matchFirstAndSecondConditionNode($identical, function (\PhpParser\Node $binaryOp) : bool {
|
|
|
|
return $binaryOp instanceof \PhpParser\Node\Expr\BinaryOp\Identical || $binaryOp instanceof \PhpParser\Node\Expr\BinaryOp\NotIdentical;
|
|
|
|
}, function (\PhpParser\Node $binaryOp) : bool {
|
2021-05-09 20:15:43 +00:00
|
|
|
return $this->valueResolver->isTrueOrFalse($binaryOp);
|
|
|
|
});
|
2021-05-10 22:23:08 +00:00
|
|
|
if (!$twoNodeMatch instanceof \Rector\Php71\ValueObject\TwoNodeMatch) {
|
2020-08-23 09:39:09 +00:00
|
|
|
return $twoNodeMatch;
|
2018-10-15 12:35:45 +00:00
|
|
|
}
|
2019-02-22 17:25:31 +00:00
|
|
|
/** @var Identical|NotIdentical $subBinaryOp */
|
2020-08-23 09:39:09 +00:00
|
|
|
$subBinaryOp = $twoNodeMatch->getFirstExpr();
|
|
|
|
$otherNode = $twoNodeMatch->getSecondExpr();
|
2021-01-30 23:20:05 +00:00
|
|
|
if ($this->valueResolver->isFalse($otherNode)) {
|
2019-02-22 17:25:31 +00:00
|
|
|
return $this->createInversedBooleanOp($subBinaryOp);
|
2018-10-15 12:35:45 +00:00
|
|
|
}
|
2019-02-22 17:25:31 +00:00
|
|
|
return $subBinaryOp;
|
2018-10-15 12:35:45 +00:00
|
|
|
}
|
|
|
|
/**
|
|
|
|
* Skip too nested binary || binary > binary combinations
|
|
|
|
*/
|
2021-07-05 22:50:18 +00:00
|
|
|
private function shouldSkip(\PhpParser\Node\Expr\BinaryOp $binaryOp) : bool
|
2018-10-15 12:35:45 +00:00
|
|
|
{
|
2021-05-10 22:23:08 +00:00
|
|
|
if ($binaryOp instanceof \PhpParser\Node\Expr\BinaryOp\BooleanOr) {
|
2021-05-09 20:15:43 +00:00
|
|
|
return \true;
|
2018-11-07 01:37:39 +00:00
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
if ($binaryOp->left instanceof \PhpParser\Node\Expr\BinaryOp) {
|
2021-05-09 20:15:43 +00:00
|
|
|
return \true;
|
2018-10-15 12:35:45 +00:00
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
return $binaryOp->right instanceof \PhpParser\Node\Expr\BinaryOp;
|
2018-10-12 23:02:47 +00:00
|
|
|
}
|
2021-05-10 22:23:08 +00:00
|
|
|
private function createInversedBooleanOp(\PhpParser\Node\Expr\BinaryOp $binaryOp) : ?\PhpParser\Node\Expr\BinaryOp
|
2018-10-31 15:34:37 +00:00
|
|
|
{
|
2019-02-22 17:25:31 +00:00
|
|
|
$inversedBinaryClass = $this->assignAndBinaryMap->getInversed($binaryOp);
|
2018-11-05 00:56:27 +00:00
|
|
|
if ($inversedBinaryClass === null) {
|
|
|
|
return null;
|
|
|
|
}
|
2019-02-22 17:25:31 +00:00
|
|
|
return new $inversedBinaryClass($binaryOp->left, $binaryOp->right);
|
2018-10-31 15:34:37 +00:00
|
|
|
}
|
2018-10-12 23:02:47 +00:00
|
|
|
}
|