2019-10-17 17:03:40 +00:00
|
|
|
<?php
|
|
|
|
|
2021-05-09 20:15:43 +00:00
|
|
|
declare (strict_types=1);
|
2022-06-06 17:12:56 +00:00
|
|
|
namespace Rector\CodeQuality\Rector\FuncCall;
|
2019-10-17 17:03:40 +00:00
|
|
|
|
2022-06-06 17:12:56 +00:00
|
|
|
use PhpParser\Node;
|
|
|
|
use PhpParser\Node\Arg;
|
|
|
|
use PhpParser\Node\Expr\Array_;
|
|
|
|
use PhpParser\Node\Expr\ArrayItem;
|
|
|
|
use PhpParser\Node\Expr\FuncCall;
|
2024-01-02 02:40:38 +00:00
|
|
|
use Rector\Rector\AbstractRector;
|
2022-06-07 09:18:30 +00:00
|
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
2019-10-17 17:03:40 +00:00
|
|
|
/**
|
2022-05-12 19:17:07 +00:00
|
|
|
* @changelog https://3v4l.org/aLf96
|
|
|
|
* @changelog https://3v4l.org/2r26K
|
|
|
|
* @changelog https://3v4l.org/anks3
|
2019-10-17 17:03:40 +00:00
|
|
|
*
|
2021-03-12 22:20:25 +00:00
|
|
|
* @see \Rector\Tests\CodeQuality\Rector\FuncCall\ArrayMergeOfNonArraysToSimpleArrayRector\ArrayMergeOfNonArraysToSimpleArrayRectorTest
|
2019-10-17 17:03:40 +00:00
|
|
|
*/
|
2022-06-07 08:22:29 +00:00
|
|
|
final class ArrayMergeOfNonArraysToSimpleArrayRector extends AbstractRector
|
2019-10-17 17:03:40 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
public function getRuleDefinition() : RuleDefinition
|
2019-10-17 17:03:40 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
return new RuleDefinition('Change array_merge of non arrays to array directly', [new CodeSample(<<<'CODE_SAMPLE'
|
2019-10-17 17:03:40 +00:00
|
|
|
class SomeClass
|
|
|
|
{
|
|
|
|
public function go()
|
|
|
|
{
|
|
|
|
$value = 5;
|
|
|
|
$value2 = 10;
|
|
|
|
|
2019-10-18 14:05:26 +00:00
|
|
|
return array_merge([$value], [$value2]);
|
2019-10-17 17:03:40 +00:00
|
|
|
}
|
|
|
|
}
|
2020-09-15 08:23:13 +00:00
|
|
|
CODE_SAMPLE
|
2021-05-09 20:15:43 +00:00
|
|
|
, <<<'CODE_SAMPLE'
|
2019-10-17 17:03:40 +00:00
|
|
|
class SomeClass
|
|
|
|
{
|
|
|
|
public function go()
|
|
|
|
{
|
|
|
|
$value = 5;
|
|
|
|
$value2 = 10;
|
|
|
|
|
|
|
|
return [$value, $value2];
|
|
|
|
}
|
|
|
|
}
|
2020-09-15 08:23:13 +00:00
|
|
|
CODE_SAMPLE
|
2021-05-09 20:15:43 +00:00
|
|
|
)]);
|
2019-10-17 17:03:40 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-02-27 00:06:15 +00:00
|
|
|
* @return array<class-string<Node>>
|
2019-10-17 17:03:40 +00:00
|
|
|
*/
|
2021-05-09 20:15:43 +00:00
|
|
|
public function getNodeTypes() : array
|
2019-10-17 17:03:40 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
return [FuncCall::class];
|
2019-10-17 17:03:40 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-12-10 10:22:23 +00:00
|
|
|
* @param FuncCall $node
|
2019-10-17 17:03:40 +00:00
|
|
|
*/
|
2022-06-07 08:22:29 +00:00
|
|
|
public function refactor(Node $node) : ?Node
|
2019-10-17 17:03:40 +00:00
|
|
|
{
|
2021-05-09 20:15:43 +00:00
|
|
|
if (!$this->isName($node, 'array_merge')) {
|
2019-10-17 17:03:40 +00:00
|
|
|
return null;
|
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
$array = new Array_();
|
2022-02-25 08:28:29 +00:00
|
|
|
$isAssigned = \false;
|
2019-10-17 17:03:40 +00:00
|
|
|
foreach ($node->args as $arg) {
|
2021-09-27 15:43:15 +00:00
|
|
|
// found non Arg? return early
|
2022-06-07 08:22:29 +00:00
|
|
|
if (!$arg instanceof Arg) {
|
2021-09-27 15:43:15 +00:00
|
|
|
return null;
|
|
|
|
}
|
2019-10-17 17:03:40 +00:00
|
|
|
$nestedArrayItem = $arg->value;
|
2022-06-07 08:22:29 +00:00
|
|
|
if (!$nestedArrayItem instanceof Array_) {
|
2019-10-17 17:03:40 +00:00
|
|
|
return null;
|
|
|
|
}
|
|
|
|
foreach ($nestedArrayItem->items as $nestedArrayItemItem) {
|
2023-03-23 23:21:34 +00:00
|
|
|
if (!$nestedArrayItemItem instanceof ArrayItem) {
|
2020-08-10 21:59:40 +00:00
|
|
|
continue;
|
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
$array->items[] = new ArrayItem($nestedArrayItemItem->value, $nestedArrayItemItem->key);
|
2022-02-25 08:28:29 +00:00
|
|
|
$isAssigned = \true;
|
2019-10-17 17:03:40 +00:00
|
|
|
}
|
|
|
|
}
|
2022-02-25 08:28:29 +00:00
|
|
|
if (!$isAssigned) {
|
|
|
|
return null;
|
|
|
|
}
|
2019-10-17 17:03:40 +00:00
|
|
|
return $array;
|
|
|
|
}
|
|
|
|
}
|