rector/vendor/rector/rector-symfony/src/Rector/ClassMethod/ConsoleExecuteReturnIntRector.php

186 lines
7.0 KiB
PHP
Raw Normal View History

<?php
declare (strict_types=1);
namespace Rector\Symfony\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\BinaryOp\Coalesce;
use PhpParser\Node\Expr\Cast\Int_;
use PhpParser\Node\Expr\Ternary;
use PhpParser\Node\FunctionLike;
use PhpParser\Node\Identifier;
use PhpParser\Node\Scalar\LNumber;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Return_;
use PhpParser\NodeTraverser;
use PHPStan\Type\IntegerType;
use PHPStan\Type\ObjectType;
use Rector\Core\Rector\AbstractRector;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see https://github.com/symfony/symfony/pull/33775/files
* @see \Rector\Symfony\Tests\Rector\ClassMethod\ConsoleExecuteReturnIntRector\ConsoleExecuteReturnIntRectorTest
*/
final class ConsoleExecuteReturnIntRector extends \Rector\Core\Rector\AbstractRector
{
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
{
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Returns int from Command::execute command', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
class SomeCommand extends Command
{
public function execute(InputInterface $input, OutputInterface $output)
{
return null;
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeCommand extends Command
{
public function execute(InputInterface $input, OutputInterface $output): int
{
return 0;
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [\PhpParser\Node\Stmt\ClassMethod::class];
}
/**
* @param ClassMethod $node
*/
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
{
if (!$this->isName($node, 'execute')) {
return null;
}
$class = $this->betterNodeFinder->findParentType($node, \PhpParser\Node\Stmt\Class_::class);
if (!$class instanceof \PhpParser\Node\Stmt\Class_) {
return null;
}
if (!$this->isObjectType($class, new \PHPStan\Type\ObjectType('Symfony\\Component\\Console\\Command\\Command'))) {
return null;
}
$this->refactorReturnTypeDeclaration($node);
$this->addReturn0ToMethod($node);
return $node;
}
private function refactorReturnTypeDeclaration(\PhpParser\Node\Stmt\ClassMethod $classMethod) : void
{
// already set
if ($classMethod->returnType !== null && $this->isName($classMethod->returnType, 'int')) {
return;
}
$classMethod->returnType = new \PhpParser\Node\Identifier('int');
}
private function addReturn0ToMethod(\PhpParser\Node\Stmt\ClassMethod $classMethod) : void
{
$hasReturn = \false;
$this->traverseNodesWithCallable((array) $classMethod->getStmts(), function (\PhpParser\Node $node) use($classMethod, &$hasReturn) : ?int {
if ($node instanceof \PhpParser\Node\FunctionLike) {
return \PhpParser\NodeTraverser::DONT_TRAVERSE_CHILDREN;
}
$parentNode = $node->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::PARENT_NODE);
if ($parentNode instanceof \PhpParser\Node && $this->isReturnWithExprIntEquals($parentNode, $node)) {
$hasReturn = \true;
return null;
}
if (!$node instanceof \PhpParser\Node\Stmt\Return_) {
return null;
}
if ($node->expr instanceof \PhpParser\Node\Expr\Cast\Int_) {
return null;
}
if ($node->expr instanceof \PhpParser\Node\Expr\Ternary && $this->isIntegerTernaryIfElse($node->expr)) {
$hasReturn = \true;
return null;
}
// is there return without nesting?
if ($this->nodeComparator->areNodesEqual($parentNode, $classMethod)) {
$hasReturn = \true;
}
$this->setReturnTo0InsteadOfNull($node);
return null;
});
$this->processReturn0ToMethod($hasReturn, $classMethod);
}
private function isIntegerTernaryIfElse(\PhpParser\Node\Expr\Ternary $ternary) : bool
{
/** @var Expr|null $if */
$if = $ternary->if;
if (!$if instanceof \PhpParser\Node\Expr) {
$if = $ternary->cond;
}
/** @var Expr $else */
$else = $ternary->else;
$ifType = $this->getType($if);
$elseType = $this->getType($else);
return $ifType instanceof \PHPStan\Type\IntegerType && $elseType instanceof \PHPStan\Type\IntegerType;
}
private function processReturn0ToMethod(bool $hasReturn, \PhpParser\Node\Stmt\ClassMethod $classMethod) : void
{
if ($hasReturn) {
return;
}
$classMethod->stmts[] = new \PhpParser\Node\Stmt\Return_(new \PhpParser\Node\Scalar\LNumber(0));
}
private function isReturnWithExprIntEquals(\PhpParser\Node $parentNode, \PhpParser\Node $node) : bool
{
if (!$parentNode instanceof \PhpParser\Node\Stmt\Return_) {
return \false;
}
if (!$this->nodeComparator->areNodesEqual($parentNode->expr, $node)) {
return \false;
}
return $node instanceof \PhpParser\Node\Expr\Cast\Int_;
}
private function setReturnTo0InsteadOfNull(\PhpParser\Node\Stmt\Return_ $return) : void
{
if ($return->expr === null) {
$return->expr = new \PhpParser\Node\Scalar\LNumber(0);
return;
}
if ($this->valueResolver->isNull($return->expr)) {
$return->expr = new \PhpParser\Node\Scalar\LNumber(0);
return;
}
if ($return->expr instanceof \PhpParser\Node\Expr\BinaryOp\Coalesce && $this->valueResolver->isNull($return->expr->right)) {
$return->expr->right = new \PhpParser\Node\Scalar\LNumber(0);
return;
}
if ($return->expr instanceof \PhpParser\Node\Expr\Ternary) {
$hasChanged = $this->isSuccessfulRefactorTernaryReturn($return->expr);
if ($hasChanged) {
return;
}
}
$staticType = $this->getType($return->expr);
if (!$staticType instanceof \PHPStan\Type\IntegerType) {
$return->expr = new \PhpParser\Node\Expr\Cast\Int_($return->expr);
}
}
private function isSuccessfulRefactorTernaryReturn(\PhpParser\Node\Expr\Ternary $ternary) : bool
{
$hasChanged = \false;
if ($ternary->if instanceof \PhpParser\Node\Expr && $this->valueResolver->isNull($ternary->if)) {
$ternary->if = new \PhpParser\Node\Scalar\LNumber(0);
$hasChanged = \true;
}
if ($this->valueResolver->isNull($ternary->else)) {
$ternary->else = new \PhpParser\Node\Scalar\LNumber(0);
$hasChanged = \true;
}
return $hasChanged;
}
}