2018-12-15 17:53:38 +00:00
|
|
|
<?php declare(strict_types=1);
|
|
|
|
|
2019-09-22 18:57:03 +00:00
|
|
|
namespace Rector\Php72\Rector\FuncCall;
|
2018-12-15 17:53:38 +00:00
|
|
|
|
|
|
|
use PhpParser\Node;
|
2018-12-15 21:05:44 +00:00
|
|
|
use PhpParser\Node\Arg;
|
|
|
|
use PhpParser\Node\Expr;
|
2019-02-23 09:32:27 +00:00
|
|
|
use PhpParser\Node\Expr\Assign;
|
2018-12-15 21:05:44 +00:00
|
|
|
use PhpParser\Node\Expr\BinaryOp\Concat;
|
2018-12-15 17:53:38 +00:00
|
|
|
use PhpParser\Node\Expr\Closure;
|
|
|
|
use PhpParser\Node\Expr\ClosureUse;
|
|
|
|
use PhpParser\Node\Expr\FuncCall;
|
|
|
|
use PhpParser\Node\Expr\Variable;
|
2018-12-15 21:05:44 +00:00
|
|
|
use PhpParser\Node\Name;
|
2018-12-15 17:53:38 +00:00
|
|
|
use PhpParser\Node\Param;
|
|
|
|
use PhpParser\Node\Scalar\Encapsed;
|
|
|
|
use PhpParser\Node\Scalar\String_;
|
|
|
|
use PhpParser\Node\Stmt;
|
|
|
|
use PhpParser\Node\Stmt\Expression;
|
2019-04-13 09:20:27 +00:00
|
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
2019-02-23 09:32:27 +00:00
|
|
|
use Rector\PhpParser\Parser\InlineCodeParser;
|
2018-12-15 17:53:38 +00:00
|
|
|
use Rector\Rector\AbstractRector;
|
|
|
|
use Rector\RectorDefinition\CodeSample;
|
|
|
|
use Rector\RectorDefinition\RectorDefinition;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @see https://stackoverflow.com/q/48161526/1348344
|
|
|
|
* @see http://php.net/manual/en/migration72.deprecated.php#migration72.deprecated.create_function-function
|
2019-09-23 11:43:13 +00:00
|
|
|
* @see \Rector\Php72\Tests\Rector\FuncCall\CreateFunctionToAnonymousFunctionRector\CreateFunctionToAnonymousFunctionRectorTest
|
2018-12-15 17:53:38 +00:00
|
|
|
*/
|
|
|
|
final class CreateFunctionToAnonymousFunctionRector extends AbstractRector
|
|
|
|
{
|
|
|
|
/**
|
2019-02-23 09:32:27 +00:00
|
|
|
* @var InlineCodeParser
|
2018-12-15 17:53:38 +00:00
|
|
|
*/
|
2019-02-23 09:32:27 +00:00
|
|
|
private $inlineCodeParser;
|
2018-12-15 17:53:38 +00:00
|
|
|
|
2019-03-26 22:56:10 +00:00
|
|
|
public function __construct(InlineCodeParser $inlineCodeParser)
|
2018-12-15 17:53:38 +00:00
|
|
|
{
|
2019-02-23 09:32:27 +00:00
|
|
|
$this->inlineCodeParser = $inlineCodeParser;
|
2018-12-15 17:53:38 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
public function getDefinition(): RectorDefinition
|
|
|
|
{
|
|
|
|
return new RectorDefinition('Use anonymous functions instead of deprecated create_function()', [
|
|
|
|
new CodeSample(
|
2019-09-18 06:14:35 +00:00
|
|
|
<<<'PHP'
|
2018-12-15 17:53:38 +00:00
|
|
|
class ClassWithCreateFunction
|
|
|
|
{
|
|
|
|
public function run()
|
|
|
|
{
|
|
|
|
$callable = create_function('$matches', "return '$delimiter' . strtolower(\$matches[1]);");
|
|
|
|
}
|
|
|
|
}
|
2019-09-18 06:14:35 +00:00
|
|
|
PHP
|
2018-12-15 17:53:38 +00:00
|
|
|
,
|
2019-09-18 06:14:35 +00:00
|
|
|
<<<'PHP'
|
2018-12-15 17:53:38 +00:00
|
|
|
class ClassWithCreateFunction
|
|
|
|
{
|
|
|
|
public function run()
|
|
|
|
{
|
|
|
|
$callable = function($matches) use ($delimiter) {
|
|
|
|
return $delimiter . strtolower($matches[1]);
|
|
|
|
};
|
|
|
|
}
|
|
|
|
}
|
2019-09-18 06:14:35 +00:00
|
|
|
PHP
|
2018-12-15 17:53:38 +00:00
|
|
|
),
|
|
|
|
]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return string[]
|
|
|
|
*/
|
|
|
|
public function getNodeTypes(): array
|
|
|
|
{
|
|
|
|
return [FuncCall::class];
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @param FuncCall $node
|
|
|
|
*/
|
|
|
|
public function refactor(Node $node): ?Node
|
|
|
|
{
|
|
|
|
if (! $this->isName($node, 'create_function')) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
/** @var Variable[] $parameters */
|
2018-12-15 21:05:44 +00:00
|
|
|
$parameters = $this->parseStringToParameters($node->args[0]->value);
|
|
|
|
$body = $this->parseStringToBody($node->args[1]->value);
|
2018-12-15 17:53:38 +00:00
|
|
|
$useVariables = $this->resolveUseVariables($body, $parameters);
|
|
|
|
|
|
|
|
$anonymousFunctionNode = new Closure();
|
2018-12-15 21:05:44 +00:00
|
|
|
|
2018-12-15 17:53:38 +00:00
|
|
|
foreach ($parameters as $parameter) {
|
|
|
|
/** @var Variable $parameter */
|
|
|
|
$anonymousFunctionNode->params[] = new Param($parameter);
|
|
|
|
}
|
|
|
|
|
2019-02-17 14:12:47 +00:00
|
|
|
if ($body !== []) {
|
2018-12-15 17:53:38 +00:00
|
|
|
$anonymousFunctionNode->stmts = $body;
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach ($useVariables as $useVariable) {
|
|
|
|
$anonymousFunctionNode->uses[] = new ClosureUse($useVariable);
|
|
|
|
}
|
|
|
|
|
|
|
|
return $anonymousFunctionNode;
|
|
|
|
}
|
|
|
|
|
2018-12-16 13:24:31 +00:00
|
|
|
/**
|
|
|
|
* @return Param[]
|
|
|
|
*/
|
|
|
|
private function parseStringToParameters(Expr $expr): array
|
|
|
|
{
|
2019-02-23 09:32:27 +00:00
|
|
|
$content = $this->inlineCodeParser->stringify($expr);
|
2018-12-16 13:24:31 +00:00
|
|
|
$content = '<?php $value = function(' . $content . ') {};';
|
|
|
|
|
2019-02-23 09:32:27 +00:00
|
|
|
$nodes = $this->inlineCodeParser->parse($content);
|
2018-12-16 13:24:31 +00:00
|
|
|
|
|
|
|
return $nodes[0]->expr->expr->params;
|
|
|
|
}
|
|
|
|
|
2018-12-15 17:53:38 +00:00
|
|
|
/**
|
2019-02-22 17:25:31 +00:00
|
|
|
* @param String_|Expr $node
|
2018-12-15 21:05:44 +00:00
|
|
|
* @return Stmt[]
|
2018-12-15 17:53:38 +00:00
|
|
|
*/
|
2019-02-22 17:25:31 +00:00
|
|
|
private function parseStringToBody(Node $node): array
|
2018-12-15 17:53:38 +00:00
|
|
|
{
|
2019-02-22 17:25:31 +00:00
|
|
|
if (! $node instanceof String_ && ! $node instanceof Encapsed && ! $node instanceof Concat) {
|
2018-12-15 21:05:44 +00:00
|
|
|
// special case of code elsewhere
|
2019-02-22 17:25:31 +00:00
|
|
|
return [$this->createEval($node)];
|
2018-12-15 17:53:38 +00:00
|
|
|
}
|
|
|
|
|
2019-02-23 09:32:27 +00:00
|
|
|
$node = $this->inlineCodeParser->stringify($node);
|
2018-12-15 17:53:38 +00:00
|
|
|
|
2019-02-23 09:32:27 +00:00
|
|
|
return $this->inlineCodeParser->parse($node);
|
2018-12-15 21:05:44 +00:00
|
|
|
}
|
2018-12-15 17:53:38 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @param Node[] $nodes
|
|
|
|
* @param Variable[] $paramNodes
|
|
|
|
* @return Variable[]
|
|
|
|
*/
|
|
|
|
private function resolveUseVariables(array $nodes, array $paramNodes): array
|
|
|
|
{
|
|
|
|
$paramNames = [];
|
|
|
|
foreach ($paramNodes as $paramNode) {
|
|
|
|
$paramNames[] = $this->getName($paramNode);
|
|
|
|
}
|
|
|
|
|
|
|
|
$variableNodes = $this->betterNodeFinder->findInstanceOf($nodes, Variable::class);
|
2018-12-15 21:05:44 +00:00
|
|
|
|
|
|
|
$filteredVariables = [];
|
2019-02-23 09:32:27 +00:00
|
|
|
$alreadyAssignedVariables = [];
|
2018-12-15 21:05:44 +00:00
|
|
|
foreach ($variableNodes as $variableNode) {
|
|
|
|
// "$this" is allowed
|
|
|
|
if ($this->isName($variableNode, 'this')) {
|
2018-12-15 17:53:38 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2019-01-25 14:59:40 +00:00
|
|
|
$variableName = $this->getName($variableNode);
|
2019-02-23 09:32:27 +00:00
|
|
|
if ($variableName === null) {
|
2018-12-15 21:05:44 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2019-02-23 09:32:27 +00:00
|
|
|
if (in_array($variableName, $paramNames, true)) {
|
|
|
|
continue;
|
|
|
|
}
|
2018-12-15 21:05:44 +00:00
|
|
|
|
2019-08-29 20:44:30 +00:00
|
|
|
$parentNode = $variableNode->getAttribute(AttributeKey::PARENT_NODE);
|
|
|
|
if ($parentNode instanceof Assign) {
|
2019-02-23 09:32:27 +00:00
|
|
|
$alreadyAssignedVariables[] = $variableName;
|
|
|
|
}
|
2018-12-15 21:05:44 +00:00
|
|
|
|
2019-02-23 09:32:27 +00:00
|
|
|
if ($this->isNames($variableNode, $alreadyAssignedVariables)) {
|
|
|
|
continue;
|
|
|
|
}
|
2018-12-15 21:05:44 +00:00
|
|
|
|
2019-02-23 09:32:27 +00:00
|
|
|
$filteredVariables[$variableName] = $variableNode;
|
2018-12-15 21:05:44 +00:00
|
|
|
}
|
|
|
|
|
2019-02-23 09:32:27 +00:00
|
|
|
return $filteredVariables;
|
2018-12-15 21:05:44 +00:00
|
|
|
}
|
|
|
|
|
2019-02-22 17:25:31 +00:00
|
|
|
private function createEval(Expr $expr): Expression
|
2018-12-15 21:05:44 +00:00
|
|
|
{
|
2019-02-22 17:25:31 +00:00
|
|
|
$evalFuncCall = new FuncCall(new Name('eval'), [new Arg($expr)]);
|
2018-12-15 21:05:44 +00:00
|
|
|
|
|
|
|
return new Expression($evalFuncCall);
|
2018-12-15 17:53:38 +00:00
|
|
|
}
|
|
|
|
}
|