rector/packages/CodeQuality/src/Rector/If_/CombineIfRector.php

103 lines
2.0 KiB
PHP
Raw Normal View History

2020-01-15 19:41:42 +00:00
<?php
declare(strict_types=1);
namespace Rector\CodeQuality\Rector\If_;
use PhpParser\Node;
2020-01-15 20:48:14 +00:00
use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
2020-01-15 19:41:42 +00:00
use PhpParser\Node\Stmt\If_;
use Rector\Rector\AbstractRector;
use Rector\RectorDefinition\CodeSample;
use Rector\RectorDefinition\RectorDefinition;
/**
* @see \Rector\CodeQuality\Tests\Rector\If_\CombineIfRector\CombineIfRectorTest
*/
final class CombineIfRector extends AbstractRector
{
public function getDefinition(): RectorDefinition
{
return new RectorDefinition('Merges nested if statements', [
new CodeSample(
<<<'PHP'
class SomeClass {
public function run()
{
if ($cond1) {
if ($cond2) {
return 'foo';
}
}
}
}
PHP
,
<<<'PHP'
class SomeClass {
public function run()
{
if ($cond1 && $cond2) {
return 'foo';
}
}
}
PHP
),
]);
}
/**
* @return string[]
*/
public function getNodeTypes(): array
{
return [If_::class];
}
/**
* @param If_ $node
*/
public function refactor(Node $node): ?Node
{
if ($this->shouldSkip($node)) {
return null;
}
/** @var Node\Stmt\If_ $subIf */
$subIf = $node->stmts[0];
$node->cond = new BooleanAnd($node->cond, $subIf->cond);
$node->stmts = $subIf->stmts;
return $node;
}
private function shouldSkip(If_ $node): bool
{
if ($node->else !== null) {
return true;
}
if (count($node->stmts) !== 1) {
return true;
}
if ($node->elseifs) {
return true;
}
if (! $node->stmts[0] instanceof If_) {
return true;
}
if ($node->stmts[0]->else !== null) {
return true;
}
if ($node->stmts[0]->elseifs) {
return true;
}
return false;
}
}